From: Leo <sdl.web@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 6999@debbugs.gnu.org
Subject: bug#6999: 23.2; [PATCH] appt ignores included diary files
Date: Tue, 14 Sep 2010 07:19:46 +0100 [thread overview]
Message-ID: <m1eicwc0e5.fsf@cam.ac.uk> (raw)
In-Reply-To: <hraanl5g0i.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 13 Sep 2010 20:24:13 -0400")
On 2010-09-14 01:24 +0100, Glenn Morris wrote:
> Leo wrote:
>
>> - (and (string-equal buffer-file-name (expand-file-name diary-file))
>> + (and (or (string-equal buffer-file-name (expand-file-name diary-file))
>> + (eq major-mode 'diary-mode))
>
> There's no particular reason that the included diary files should be
> being visited in diary-mode. I'll try to find a different fix (I'm
> thinking maybe running diary-list-entries should store a list of any
> include files that were found).
But the point of that is to decide whether to call appt-check (hence
diary-list-entries, which is expensive). Looks like somehow diary-lib
needs a function to return all included files without doing list
entries. Thanks for looking into this.
Leo
next prev parent reply other threads:[~2010-09-14 6:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 12:31 bug#6999: 23.2; [PATCH] appt ignores included diary files Leo
2010-09-08 12:45 ` Leo
2010-09-08 14:38 ` Stefan Monnier
2010-09-08 15:07 ` Leo
2010-09-14 0:24 ` Glenn Morris
2010-09-14 6:19 ` Leo [this message]
2010-09-14 7:20 ` Glenn Morris
2010-09-14 7:38 ` Leo
2010-09-14 8:06 ` Glenn Morris
2010-09-15 2:49 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1eicwc0e5.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=6999@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.