* bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar
@ 2017-04-12 15:40 Fox Kiester
2017-04-12 19:18 ` Glenn Morris
2017-04-12 19:44 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Fox Kiester @ 2017-04-12 15:40 UTC (permalink / raw)
To: 26466
I learned today that kill-this-buffer is only meant to be called from the menu bar. This is clear after navigating to its definition in menu-bar.el, but it would be nice if this was also mentioned in its docstring especially since the command is not prefixed with "menu-bar-". This might help prevent some confusion.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar
2017-04-12 15:40 bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar Fox Kiester
@ 2017-04-12 19:18 ` Glenn Morris
2017-04-12 20:15 ` Eli Zaretskii
2017-04-12 19:44 ` Eli Zaretskii
1 sibling, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2017-04-12 19:18 UTC (permalink / raw)
To: Fox Kiester; +Cc: 26466
Fox Kiester wrote:
> I learned today that kill-this-buffer is only meant to be called from
> the menu bar. This is clear after navigating to its definition in
> menu-bar.el, but it would be nice if this was also mentioned in its
> docstring especially since the command is not prefixed with
> "menu-bar-". This might help prevent some confusion.
And yet several places call it not from the menu-bar.
Eg completion-list-mode-map.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar
2017-04-12 19:18 ` Glenn Morris
@ 2017-04-12 20:15 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2017-04-12 20:15 UTC (permalink / raw)
To: Glenn Morris; +Cc: noct, 26466
> From: Glenn Morris <rgm@gnu.org>
> Date: Wed, 12 Apr 2017 15:18:12 -0400
> Cc: 26466@debbugs.gnu.org
>
> Fox Kiester wrote:
>
> > I learned today that kill-this-buffer is only meant to be called from
> > the menu bar. This is clear after navigating to its definition in
> > menu-bar.el, but it would be nice if this was also mentioned in its
> > docstring especially since the command is not prefixed with
> > "menu-bar-". This might help prevent some confusion.
>
> And yet several places call it not from the menu-bar.
Thanks, I made them call another function instead.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar
2017-04-12 15:40 bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar Fox Kiester
2017-04-12 19:18 ` Glenn Morris
@ 2017-04-12 19:44 ` Eli Zaretskii
2017-04-12 20:00 ` Glenn Morris
1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2017-04-12 19:44 UTC (permalink / raw)
To: Fox Kiester; +Cc: 26466-done
> From: Fox Kiester <noct@openmailbox.org>
> Date: Wed, 12 Apr 2017 11:40:46 -0400
>
> I learned today that kill-this-buffer is only meant to be called from the menu bar. This is clear after navigating to its definition in menu-bar.el, but it would be nice if this was also mentioned in its docstring especially since the command is not prefixed with "menu-bar-". This might help prevent some confusion.
More accurately, this command might decide to silently do nothing if
invoked not vie the menu bar.
I augmented the doc string to say that, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar
2017-04-12 19:44 ` Eli Zaretskii
@ 2017-04-12 20:00 ` Glenn Morris
2017-04-12 20:30 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2017-04-12 20:00 UTC (permalink / raw)
To: 26466; +Cc: noct
Eli Zaretskii wrote:
>> From: Fox Kiester <noct@openmailbox.org>
>> Date: Wed, 12 Apr 2017 11:40:46 -0400
>>
>> I learned today that kill-this-buffer is only meant to be called
>> from the menu bar. This is clear after navigating to its definition
>> in menu-bar.el, but it would be nice if this was also mentioned in
>> its docstring especially since the command is not prefixed with
>> "menu-bar-". This might help prevent some confusion.
>
> More accurately, this command might decide to silently do nothing if
> invoked not vie the menu bar.
Perhaps that aspect wasn't entirely intentional (yes I know it's bug#8184).
Compare the definition in Emacs 23.4:
(defun kill-this-buffer ()
"Kill the current buffer.
When called in the minibuffer, get out of the minibuffer
using `abort-recursive-edit'."
(interactive)
(if (menu-bar-non-minibuffer-window-p)
(kill-buffer (current-buffer))
(abort-recursive-edit)))
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar
2017-04-12 20:00 ` Glenn Morris
@ 2017-04-12 20:30 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2017-04-12 20:30 UTC (permalink / raw)
To: Glenn Morris; +Cc: noct, 26466
> From: Glenn Morris <rgm@gnu.org>
> Cc: eliz@gnu.org, noct@openmailbox.org
> Date: Wed, 12 Apr 2017 16:00:30 -0400
>
> Eli Zaretskii wrote:
>
> > More accurately, this command might decide to silently do nothing if
> > invoked not vie the menu bar.
>
> Perhaps that aspect wasn't entirely intentional (yes I know it's bug#8184).
How can it be not intentional, when the comment there says:
;; Don't do anything when `menu-frame' is not alive or visible
;; (Bug#8184).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-12 20:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12 15:40 bug#26466: 26.0.50; Document that kill-this-buffer should be called from the menu bar Fox Kiester
2017-04-12 19:18 ` Glenn Morris
2017-04-12 20:15 ` Eli Zaretskii
2017-04-12 19:44 ` Eli Zaretskii
2017-04-12 20:00 ` Glenn Morris
2017-04-12 20:30 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.