bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Steps to reproduce:

emacs -Q
M-x temp-buffer-resize-mode RET
M-x regexp-builder RET

Actual result:

The regexp-builder window occupies half of the frame's height (much more
than its empty contents would require).

Expected result:

The regexp-builder window takes 4 lines, just as when
temp-buffer-resize-mode is not enabled.

Workaround:

Calling M-x fit-window-to-buffer after M-x regexp-builder resizes the
window successfully.

bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Lars Ingebrigtsen]

Daniel Martín <mardani29@yahoo.es> writes:

> Steps to reproduce:
>
> emacs -Q
> M-x temp-buffer-resize-mode RET
> M-x regexp-builder RET
>
> Actual result:
>
> The regexp-builder window occupies half of the frame's height (much more
> than its empty contents would require).

I'm unable to reproduce this problem on the current trunk.  Are there
any additional steps needed?

bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Daniel Martín <mardani29@yahoo.es> writes:
>
>> Steps to reproduce:
>>
>> emacs -Q
>> M-x temp-buffer-resize-mode RET
>> M-x regexp-builder RET
>>
>> Actual result:
>>
>> The regexp-builder window occupies half of the frame's height (much more
>> than its empty contents would require).
>
> I'm unable to reproduce this problem on the current trunk.  Are there
> any additional steps needed?

The reproduction steps were not precise enough, I think.  I can
reproduce it consistently with:

emacs -Q
M-x temp-buffer-resize-mode RET
M-x regexp-builder RET
C-c C-q
C-h m
C-x o
q
M-x regexp-builder RET

This second time the window will occupy more space than necessary.

If I omit setting temp-buffer-resize-mode in the first step, I cannot
reproduce the behavior.

bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Lars Ingebrigtsen]

Daniel Martín <mardani29@yahoo.es> writes:

> The reproduction steps were not precise enough, I think.  I can
> reproduce it consistently with:
>
> emacs -Q
> M-x temp-buffer-resize-mode RET
> M-x regexp-builder RET
> C-c C-q
> C-h m
> C-x o
> q
> M-x regexp-builder RET
>
> This second time the window will occupy more space than necessary.

Thanks; with that I'm able to reproduce the problem.

bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

> Expected result:
>
> The regexp-builder window takes 4 lines, just as when
> temp-buffer-resize-mode is not enabled.
>
> Workaround:
>
> Calling M-x fit-window-to-buffer after M-x regexp-builder resizes the
> window successfully.

Before 57354bc6 it was hard-coded to 4, so a possible fix would be

              (window-height . ,(+ (if header-line-format 1 0)
                                   (if tab-line-format 1 0)
                                   4))

But a better fix is this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: re-builder-fit-window-to-buffer.patch --]
[-- Type: text/x-diff, Size: 520 bytes --]

diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el
index 46b429ce6f..84018f06ac 100644
--- a/lisp/emacs-lisp/re-builder.el
+++ b/lisp/emacs-lisp/re-builder.el
@@ -369,7 +369,8 @@ re-builder
             (get-buffer-create reb-buffer)
             `((display-buffer-in-direction)
               (direction . ,dir)
-              (dedicated . t))))))
+              (dedicated . t)
+              (window-height . fit-window-to-buffer))))))
     (font-lock-mode 1)
     (reb-initialize-buffer)))
 

[-- Attachment #3: Type: text/plain, Size: 95 bytes --]


I don't know why it resizes to less lines with tab-line-mode,
but this is a separate problem.

bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> But a better fix is this:
>
> diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el
> index 46b429ce6f..84018f06ac 100644
> --- a/lisp/emacs-lisp/re-builder.el
> +++ b/lisp/emacs-lisp/re-builder.el
> @@ -369,7 +369,8 @@ re-builder
>              (get-buffer-create reb-buffer)
>              `((display-buffer-in-direction)
>                (direction . ,dir)
> -              (dedicated . t))))))
> +              (dedicated . t)
> +              (window-height . fit-window-to-buffer))))))

So I pushed this to Emacs 29 now.