From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#64266: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix. Date: Sun, 09 Jul 2023 10:57:13 +0300 Message-ID: References: <83cz1kzyyl.fsf@gnu.org> <837crszt5u.fsf@gnu.org> <069719e0-af33-dfc5-72b4-07fb0c1dd185@gutov.dev> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19522"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: sbaugh@catern.com, Eli Zaretskii , 64266@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 09 09:58:49 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIPJh-0004uY-2J for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jul 2023 09:58:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qIPJ1-0000ju-08; Sun, 09 Jul 2023 03:58:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIPIw-0000in-FX for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 03:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIPIw-0000aJ-7U for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 03:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qIPIw-0001II-3K for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 03:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jul 2023 07:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64266 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64266-submit@debbugs.gnu.org id=B64266.16888894394922 (code B ref 64266); Sun, 09 Jul 2023 07:58:02 +0000 Original-Received: (at 64266) by debbugs.gnu.org; 9 Jul 2023 07:57:19 +0000 Original-Received: from localhost ([127.0.0.1]:45765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIPIF-0001HK-Bl for submit@debbugs.gnu.org; Sun, 09 Jul 2023 03:57:19 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:58754 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIPID-0001HC-8r for 64266@debbugs.gnu.org; Sun, 09 Jul 2023 03:57:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1688889436; bh=e4eWjbgR5wnTeSSP5uBGS9Izfz2fakK/mJnb+Fy3Cdc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ot8v2DueP9aJEqBhzaa4EygN/OiA6kz22CJPtSXywhFLwX9+zW7Bgtn/+rjltg0YS lL8JKfljF6J+kfatous2BjIguGThJeDYUB3jJDBSnkuQWEE8hqv36dFS6EIAODQfCp N7v+wHCnUCfd1XVtVi4103kwzGsl0O3YNdwaGuyKS69WjB4qx6YoqwsOpUTB/P2Cu/ Rw5r4EE6AweEKKRqJ26JDl3yDWI+29AkYelJORusxDrgDk8O3M/YM8PnoaW3gyOUFh L0ycWv/BnkRNLXKvRklZtqOSNI7chr82afbHsSqMtQeyfL5j01ncXeOJf9F7+7+D/G 0Mnqn6pexrS+Q== In-Reply-To: <069719e0-af33-dfc5-72b4-07fb0c1dd185@gutov.dev> (Dmitry Gutov's message of "Sun, 25 Jun 2023 05:20:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264824 Archived-At: --=-=-= Content-Type: text/plain Dmitry Gutov writes: > On 24/06/2023 20:06, Eli Zaretskii wrote: >> I would recommend waiting for Dmitry and Spencer to chime in, and >> submit a followup after their comments, if any. > > Your suggested versions sounds good to me too, thanks. Thanks, I'm attaching an updated patch following Eli's wording. Also CC'ing Spencer in case there are further comments. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=v2-0001-lisp-progmodes-project.el-project-current-Doc-fix.patch >From 8b41814b8dc52b50098a8282d9fb63cdec695a4e Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sat, 24 Jun 2023 17:16:19 +0300 Subject: [PATCH v2] ; * lisp/progmodes/project.el (project-current): Doc fix. Avoid saying that 'project-current' asks specifically for a directory, as it can also ask for a project's directory by other identifiers, such as the project's name, when 'project-prompter' is set to a different value than the default 'project-prompt-project-dir'. --- lisp/progmodes/project.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 56c524bcab5..0f47c217d80 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -219,8 +219,10 @@ project-current When no project is found in that directory, the result depends on the value of MAYBE-PROMPT: if it is nil or omitted, return nil, -else ask the user for a directory in which to look for the -project, and if no project is found there, return a \"transient\" +else prompt the user for the project to use. To prompt for a +project, call the function specified by `project-prompter', which +returns the directory in which to look for the project. If no +project is found in that directory, return a \"transient\" project instance. The \"transient\" project instance is a special kind of value -- 2.41.0 --=-=-=--