all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: sbaugh@catern.com, Eli Zaretskii <eliz@gnu.org>, 64266@debbugs.gnu.org
Subject: bug#64266: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix.
Date: Sun, 09 Jul 2023 10:57:13 +0300	[thread overview]
Message-ID: <m1edlhqzza.fsf@eshelyaron.com> (raw)
In-Reply-To: <069719e0-af33-dfc5-72b4-07fb0c1dd185@gutov.dev> (Dmitry Gutov's message of "Sun, 25 Jun 2023 05:20:14 +0300")

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

Dmitry Gutov <dmitry@gutov.dev> writes:

> On 24/06/2023 20:06, Eli Zaretskii wrote:
>> I would recommend waiting for Dmitry and Spencer to chime in, and
>> submit a followup after their comments, if any.
>
> Your suggested versions sounds good to me too, thanks.

Thanks, I'm attaching an updated patch following Eli's wording.

Also CC'ing Spencer in case there are further comments.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v2-0001-lisp-progmodes-project.el-project-current-Doc-fix.patch --]
[-- Type: text/x-patch, Size: 1400 bytes --]

From 8b41814b8dc52b50098a8282d9fb63cdec695a4e Mon Sep 17 00:00:00 2001
From: Eshel Yaron <me@eshelyaron.com>
Date: Sat, 24 Jun 2023 17:16:19 +0300
Subject: [PATCH v2] ; * lisp/progmodes/project.el (project-current): Doc fix.

Avoid saying that 'project-current' asks specifically for a directory,
as it can also ask for a project's directory by other identifiers,
such as the project's name, when 'project-prompter' is set to a
different value than the default 'project-prompt-project-dir'.
---
 lisp/progmodes/project.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 56c524bcab5..0f47c217d80 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -219,8 +219,10 @@ project-current
 
 When no project is found in that directory, the result depends on
 the value of MAYBE-PROMPT: if it is nil or omitted, return nil,
-else ask the user for a directory in which to look for the
-project, and if no project is found there, return a \"transient\"
+else prompt the user for the project to use.  To prompt for a
+project, call the function specified by `project-prompter', which
+returns the directory in which to look for the project.  If no
+project is found in that directory, return a \"transient\"
 project instance.
 
 The \"transient\" project instance is a special kind of value
-- 
2.41.0


  reply	other threads:[~2023-07-09  7:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 14:35 bug#64266: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-24 15:01 ` Eli Zaretskii
2023-06-24 15:32   ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-24 17:06     ` Eli Zaretskii
2023-06-25  2:20       ` Dmitry Gutov
2023-07-09  7:57         ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-07-09 13:19           ` sbaugh
2023-07-13  6:15           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1edlhqzza.fsf@eshelyaron.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=64266@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    --cc=me@eshelyaron.com \
    --cc=sbaugh@catern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.