From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68213: 30.0.50; completion-preview-tests failure in --without-x build Date: Wed, 03 Jan 2024 08:20:37 +0100 Message-ID: References: <87ttnvr7x7.fsf@pub.pink> <83plyjzmlv.fsf@gnu.org> <87bka3r4sg.fsf@pub.pink> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33748"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 68213@debbugs.gnu.org To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 03 08:21:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rKvZ9-0008X9-3r for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Jan 2024 08:21:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rKvYk-0005CS-83; Wed, 03 Jan 2024 02:21:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rKvYh-0005BX-RT for bug-gnu-emacs@gnu.org; Wed, 03 Jan 2024 02:20:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rKvYh-0003no-G4 for bug-gnu-emacs@gnu.org; Wed, 03 Jan 2024 02:20:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rKvYj-0007qg-UH for bug-gnu-emacs@gnu.org; Wed, 03 Jan 2024 02:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Jan 2024 07:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68213 X-GNU-PR-Package: emacs Original-Received: via spool by 68213-submit@debbugs.gnu.org id=B68213.170426644730129 (code B ref 68213); Wed, 03 Jan 2024 07:21:01 +0000 Original-Received: (at 68213) by debbugs.gnu.org; 3 Jan 2024 07:20:47 +0000 Original-Received: from localhost ([127.0.0.1]:51761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKvYU-0007ps-S3 for submit@debbugs.gnu.org; Wed, 03 Jan 2024 02:20:47 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:38568 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rKvYR-0007pi-03 for 68213@debbugs.gnu.org; Wed, 03 Jan 2024 02:20:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1704266439; bh=JyvDBdYWaolpBbD6iJHQdJTBZqV0mSHV8mvlvfTN4LQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=xOlzP5EuXKME5XaEGZxyQBlXYc2YqSux2RV4yz26CTA8/ZLvO9JaEt0T1xCMmTsZ6 dIG0nI1f4LSSQdcomAt+D+DJBmdqDhxPdoUEIeW6lupHmzx9KBhtuGZewyZmWgwM1f PfM0HwlDIAwuLs5oRqzyXFv7jx3Pi2IUt3538b6wIb+bNNN7Yc0D5mDOnwoYLK5rq3 yWk2v2AVfI4Ioc6tJpf2SAGexqgP/1nz7HEaRXe9pvG52/P+OI6Axt/w3k1xGvTcLQ YSlhQ/T08QGjxnmrI8Oq24+UX2PBSlaTFU2g1/mSyIlvHP8Idz1JxxXDpZGEUqruRo qS/Zyb9ehuToA== In-Reply-To: <87bka3r4sg.fsf@pub.pink> (john muhl's message of "Tue, 02 Jan 2024 11:42:52 -0600") X-Hashcash: 1:20:240103:eliz@gnu.org::iEVdtUX//Uc49UV7:0c76 X-Hashcash: 1:20:240103:68213@debbugs.gnu.org::Miuxw1D9GsUzVF9k:37m X-Hashcash: 1:20:240103:jm@pub.pink::IAyJFdrUlQurakSP:73S2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277268 Archived-At: john muhl writes: > Eshel Yaron writes: > >> FWIW, I was going to suggest the attached patch, following how >> flymake.el handles this. But if the current solution works, that seems >> just as good. >> > lisp/completion-preview-tests.el:23:2: Error: Duplicate > definition for key: "" (keymap (mouse-5 . > completion-preview-prev-candidate) (down-mouse-2 . > completion-at-point) (C-down-mouse-1 . completion-at-point) > (down-mouse-1 . completion-preview-insert)) Ah I can see that, thanks. IMO `defvar-keymap` is too strict in this case: the "duplicate" definition is not erroneous, it just happens to be redundant with some values of the `mwheel` variables. There's been some discussion around that in bug#56873, FWIW. So ISTM that the best way forward would be to make `defvar-keymap` more lax, perhaps optionally with a `:lax` keyword argument or some such. Any other ideas?