bug#4467: 23.1.50; nsterm.m FTBFS on OS X 10.6

[Ian Eure <ian.eure@gmail.com>]

Git master fails to build from source on Mac OS X 10.6 Snow Leopard. I’m
using rev 053af44c11552da70da31fe683f33c2af126b498.

Compilation fails with:

gcc -c  -Demacs -DHAVE_CONFIG_H  -I. -I/Users/ieure/Projects/emacs/src -Dtemacs    -g -O2 -Wno-pointer-sign   nsterm.m
In file included from nsterm.h:20,
                 from nsterm.m:41:
dispextern.h:1250: error: array type has incomplete element type
nsterm.m: In function ‘ns_color_to_lisp’:
nsterm.m:1499: warning: passing argument 1 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1499: warning: passing argument 2 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1499: warning: passing argument 3 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1499: warning: passing argument 4 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1503: warning: passing argument 1 of ‘getWhite:alpha:’ from incompatible pointer type
nsterm.m:1503: warning: passing argument 2 of ‘getWhite:alpha:’ from incompatible pointer type
nsterm.m:1504: warning: '0' flag ignored with precision and ‘%x’ printf format
nsterm.m:1504: warning: '0' flag ignored with precision and ‘%x’ printf format
nsterm.m:1504: warning: '0' flag ignored with precision and ‘%x’ printf format
nsterm.m:1510: warning: '0' flag ignored with precision and ‘%x’ printf format
nsterm.m:1510: warning: '0' flag ignored with precision and ‘%x’ printf format
nsterm.m:1510: warning: '0' flag ignored with precision and ‘%x’ printf format
nsterm.m: In function ‘ns_query_color’:
nsterm.m:1528: warning: passing argument 1 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1528: warning: passing argument 2 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1528: warning: passing argument 3 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m:1528: warning: passing argument 4 of ‘getRed:green:blue:alpha:’ from incompatible pointer type
nsterm.m: In function ‘note_mouse_movement’:
nsterm.m:1693: warning: passing argument 4 of ‘remember_mouse_glyph’ from incompatible pointer type
nsterm.m: In function ‘ns_mouse_position’:
nsterm.m:1762: warning: passing argument 4 of ‘remember_mouse_glyph’ from incompatible pointer type
nsterm.m: In function ‘ns_get_glyph_string_clip_rect’:
nsterm.m:2479: error: dereferencing pointer to incomplete type
nsterm.m:2479: error: dereferencing pointer to incomplete type
nsterm.m:2482: error: dereferencing pointer to incomplete type
nsterm.m:2482: error: invalid use of undefined type ‘struct _NSRect’
nsterm.m:2482: error: dereferencing pointer to incomplete type
nsterm.m: In function ‘ns_dumpglyphs_stretch’:
nsterm.m:2850: warning: passing argument 2 of ‘ns_get_glyph_string_clip_rect’ from incompatible pointer type
nsterm.m: In function ‘ns_draw_glyph_string’:
nsterm.m:2934: warning: passing argument 2 of ‘ns_get_glyph_string_clip_rect’ from incompatible pointer type
nsterm.m:2951: warning: passing argument 2 of ‘ns_get_glyph_string_clip_rect’ from incompatible pointer type
nsterm.m:2963: warning: passing argument 2 of ‘ns_get_glyph_string_clip_rect’ from incompatible pointer type
nsterm.m:2975: warning: passing argument 2 of ‘ns_get_glyph_string_clip_rect’ from incompatible pointer type
nsterm.m:3008: warning: passing argument 2 of ‘ns_get_glyph_string_clip_rect’ from incompatible pointer type
nsterm.m: In function ‘-[EmacsView keyDown:]’:
nsterm.m:4536: warning: ‘wantsToDelayTextChangeNotifications’ is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:112)
nsterm.m: In function ‘-[EmacsView characterIndexForPoint:]’:
nsterm.m:4745: warning: conflicting types for ‘-(unsigned int)characterIndexForPoint:(NSPoint)thePoint’
/System/Library/Frameworks/AppKit.framework/Headers/NSInputManager.h:45: warning: previous declaration of ‘-(NSUInteger)characterIndexForPoint:(NSPoint)thePoint’
nsterm.m: In function ‘-[EmacsView initFrameFromEmacs:]’:
nsterm.m:5144: warning: class 'EmacsView' does not implement the 'NSWindowDelegate' protocol
nsterm.m: In function ‘-[EmacsView draggingEntered:]’:
nsterm.m:5422: warning: conflicting types for ‘-(unsigned int)draggingEntered:(id <NSDraggingInfo>)sender’
/System/Library/Frameworks/AppKit.framework/Headers/NSDragging.h:56: warning: previous declaration of ‘-(NSDragOperation)draggingEntered:(id <NSDraggingInfo>)sender’
nsterm.m: In function ‘+[EmacsScroller scrollerWidth]’:
nsterm.m:5707: warning: conflicting types for ‘+(float)scrollerWidth’
/System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:76: warning: previous declaration of ‘+(CGFloat)scrollerWidth’
nsterm.m: In function ‘-[EmacsScroller setPosition:portion:whole:]’:
nsterm.m:5837: warning: ‘setFloatValue:knobProportion:’ is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:107)
nsterm.m:5844: warning: ‘setFloatValue:knobProportion:’ is deprecated (declared at /System/Library/Frameworks/AppKit.framework/Headers/NSScroller.h:107)
nsterm.m: In function ‘-[EmacsScroller mouseDown:]’:
nsterm.m:5949: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘NSScrollerPart’
make[1]: *** [nsterm.o] Error 1
make: *** [src] Error 2



In GNU Emacs 23.1.50.1 (i386-apple-darwin9.8.0, NS apple-appkit-949.54)
 of 2009-08-28 on black.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Python

Minor modes in effect:
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-spelling-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-match-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-readonly-mode: t
  erc-scrolltobottom-mode: t
  test-case-global-mode: t
  goto-address-prog-mode: t
  light-symbol-mode: t
  hl-line-mode: t
  which-function-mode: t
  yas/minor-mode: t
  shell-dirtrack-mode: t
  ime-bindings: t
  show-paren-mode: t
  recentf-mode: t
  iswitchb-mode: t
  cua-mode: t
  auto-insert-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
M-x r e p o r t <tab> <return>

Recent messages:
Mark set [2 times]
Undo! [3 times]
Mark set
Auto-saving...done
Mark set
Auto-saving...done

Load-path shadows:
/Users/ieure/.emacs.d/ime-lisp/ime-dired hides /Users/ieure/.emacs.d/lisp/ime-dired
/Users/ieure/.emacs.d/lisp/json hides /Applications/Emacs.app/Contents/Resources/lisp/json