From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands Date: Mon, 06 Sep 2010 18:52:25 +0100 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1283796616 28183 80.91.229.12 (6 Sep 2010 18:10:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Sep 2010 18:10:16 +0000 (UTC) Cc: 6076@debbugs.gnu.org, Ryan Yeske To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 06 20:10:14 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Osg8z-0004SR-6B for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Sep 2010 20:10:13 +0200 Original-Received: from localhost ([127.0.0.1]:45363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Osg8y-00072m-Hg for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Sep 2010 14:10:12 -0400 Original-Received: from [140.186.70.92] (port=45955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Osg8q-00070X-OJ for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2010 14:10:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Osg8p-00016N-MB for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2010 14:10:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49153) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Osg8p-00016J-Kp for bug-gnu-emacs@gnu.org; Mon, 06 Sep 2010 14:10:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OsfqQ-00088X-CW; Mon, 06 Sep 2010 13:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Sep 2010 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6076-submit@debbugs.gnu.org id=B6076.128379543531267 (code B ref 6076); Mon, 06 Sep 2010 17:51:02 +0000 Original-Received: (at 6076) by debbugs.gnu.org; 6 Sep 2010 17:50:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Osfpy-00088G-UY for submit@debbugs.gnu.org; Mon, 06 Sep 2010 13:50:35 -0400 Original-Received: from ppsw-31.csi.cam.ac.uk ([131.111.8.131]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Osfpx-00088A-LT for 6076@debbugs.gnu.org; Mon, 06 Sep 2010 13:50:34 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:57562 helo=Victoria.local) by ppsw-31.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Osfrn-0001Cv-Jm (Exim 4.72) (return-path ); Mon, 06 Sep 2010 18:52:27 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 04 Sep 2010 23:44:21 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (Mac OS X 10.6.4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 06 Sep 2010 13:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40009 Archived-At: On 2010-09-04 22:44 +0100, Stefan Monnier wrote: >> I have recreated the patch against emacs-23 as suggested. I have also >> briefly tested it. Seems to work as expected. M-TAB in rcirc-mode now >> uses the new completion at point interface. > > Looks goot to me, > > > Stefan I have been using it over the weekend and nothing abnormal found. But maybe apply the following minor tweaks on top of the previous patch. diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index cade679..7a43678 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -794,11 +794,12 @@ The list is updated automatically by `defun-rcirc-command'.") (if (re-search-backward " " rcirc-prompt-end-marker t) (1+ (point)) rcirc-prompt-end-marker))) - (table (if (and (eq beg rcirc-prompt-end-marker) + (table (if (and (= beg rcirc-prompt-end-marker) (eq (char-after beg) ?/)) (delete-dups - (append (sort (copy-sequence rcirc-client-commands) 'string-lessp) - (sort (copy-sequence rcirc-server-commands) 'string-lessp))) + (nconc + (sort (copy-sequence rcirc-client-commands) 'string-lessp) + (sort (copy-sequence rcirc-server-commands) 'string-lessp))) (rcirc-channel-nicks (rcirc-buffer-process) rcirc-target)))) (list beg (point) table))) Leo