From: Leo Liu <sdl.web@gmail.com>
To: emacs-devel@gnu.org
Cc: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)
Date: Wed, 28 Dec 2016 09:38:12 +0800 [thread overview]
Message-ID: <m1d1gcygsb.fsf@gmail.com> (raw)
In-Reply-To: <20161227174437.B08552201C7@vcs.savannah.gnu.org> (Stefan Monnier's message of "Tue, 27 Dec 2016 17:44:37 +0000 (UTC)")
On 2016-12-27 17:44 +0000, Stefan Monnier wrote:
> branch: master
> commit e6161f648903d821865b9610b3b6aa0f82a5dcb7
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280)
>
> (inline--dont-quote): Quote the function with #' when passing it to `apply'.
> ---
> lisp/emacs-lisp/inline.el | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lisp/emacs-lisp/inline.el b/lisp/emacs-lisp/inline.el
> index 058c56c..5ceb0d9 100644
> --- a/lisp/emacs-lisp/inline.el
> +++ b/lisp/emacs-lisp/inline.el
> @@ -191,9 +191,9 @@ After VARS is handled, BODY is evaluated in the new environment."
> (while (and (consp exp) (not (eq '\, (car exp))))
> (push (inline--dont-quote (pop exp)) args))
> (setq args (nreverse args))
> - (if exp
> - `(apply ,@args ,(inline--dont-quote exp))
> - args)))
> + (if (null exp)
> + args
> + `(apply #',(car args) ,@(cdr args) ,(inline--dont-quote exp)))))
> (_ exp)))
>
> (defun inline--do-leteval (var-exp &rest body)
>
Could we have this bug fixed in emacs-25? inline.el is new in 25.1 and
broken. We should make sure 25.x have a usable version. Thoughts?
Leo
next parent reply other threads:[~2016-12-28 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161227174437.22152.97374@vcs.savannah.gnu.org>
[not found] ` <20161227174437.B08552201C7@vcs.savannah.gnu.org>
2016-12-28 1:38 ` Leo Liu [this message]
2016-12-28 2:37 ` master e6161f6: * lisp/emacs-lisp/inline.el: Fix apply-conversion (bug#25280) Stefan Monnier
2016-12-28 4:43 ` John Wiegley
2016-12-28 15:42 ` Eli Zaretskii
2016-12-28 16:51 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d1gcygsb.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.