From: Leo Liu <sdl.web@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 33939@debbugs.gnu.org
Subject: bug#33939: 26.1; Avoid loading libs eagerly or unnecessarily in mhtml-mode/sgml-mode
Date: Tue, 08 Jan 2019 06:43:20 +0800 [thread overview]
Message-ID: <m1d0p8m6lz.fsf@gmail.com> (raw)
In-Reply-To: <83r2doi6lw.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Jan 2019 21:56:59 +0200")
On 2019-01-07 21:56 +0200, Eli Zaretskii wrote:
> This is OK for the emacs-26 branch, thanks.
I was bored enough to check if js.el had any low-hanging fruits and
found another one. js.el uses nothing from thingatpt since
forward-symbol now lives in subr.el. Should I go ahead and put the
following patch on emacs-26?
Sorry to discover these issues one after another. The situation is worse
than I imagined.
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index 65ffb0e0..1e2c3411 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -48,10 +48,9 @@
(require 'cc-mode)
(require 'newcomment)
-(require 'thingatpt) ; forward-symbol etc
(require 'imenu)
(require 'moz nil t)
-(require 'json nil t)
+(require 'json)
(require 'sgml-mode)
(require 'prog-mode)
next prev parent reply other threads:[~2019-01-07 22:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 2:12 bug#33939: 26.1; Avoid loading libs eagerly or unnecessarily in mhtml-mode/sgml-mode Leo Liu
2019-01-05 9:47 ` Eli Zaretskii
2019-01-06 4:34 ` Leo Liu
2019-01-06 15:25 ` Eli Zaretskii
2019-01-06 23:39 ` Leo Liu
2019-01-07 0:33 ` Leo Liu
2019-01-07 3:37 ` Eli Zaretskii
2019-01-07 4:16 ` Leo Liu
2019-01-07 19:56 ` Eli Zaretskii
2019-01-07 21:20 ` Leo Liu
2019-01-07 22:43 ` Leo Liu [this message]
2019-01-08 3:31 ` Eli Zaretskii
2019-01-08 4:40 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1d0p8m6lz.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=33939@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.