From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events Date: Wed, 10 Apr 2024 20:35:26 +0200 Message-ID: References: <171267304154.21960.14298364323940508129@vcs2.savannah.gnu.org> <20240409143042.278CDC12C36@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33788"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 10 20:36:32 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rucoA-0008Yo-Js for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Apr 2024 20:36:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rucnR-0007KF-Dw; Wed, 10 Apr 2024 14:35:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rucnE-0007JQ-Ih for emacs-devel@gnu.org; Wed, 10 Apr 2024 14:35:33 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rucnC-0001bo-VT for emacs-devel@gnu.org; Wed, 10 Apr 2024 14:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1712774128; bh=BFNV0tpWcbAGtX2Ab0tPYNTQRSpRq6RKXc6WqoRU07M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BtBaNyHORK8H2quU6xpRAOBTuvTsp1l0gRybMKJ2anl+aJGpOzvxXKbQSx/EhVXiQ VRz/cAq4PMJwejf7raMJ5vURfvfx0lh6DNjQjr54xaxWke/k830DDYHrCjY8OajbDj 6CBZNkbtwdXu3BuNlxRVb/hSouuVigXwMR+xPkyoMwvSza75msvRsICq0X0lHpybWj fqjYX91ww833VMSZWnGU53AS5+3Uy9krN3dkZX6of8OmmjW3PxWCLZcJ+gfugj9YQM IaHT1tCuB8I4M/60oAEDqavTvpoPfaYrDzZM0+kIHW0uavzUt+qqPIYpgVc4RlHhFW FfgOmksVsY8fA== In-Reply-To: (Stefan Monnier's message of "Tue, 09 Apr 2024 16:39:57 -0400") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317670 Archived-At: Stefan Monnier writes: >> I wonder whether/why we should keep the bindings that use >> mouse-wheel-up/down-event here. Do I understand correctly that since we >> already bind wheel-down/up directly, we should now be able to simply >> remove these additional bindings? > > I had an earlier patch which was "more radical" in this way, but in the > end went with this half-way patch where people can set > `mouse-wheel-buttons` to nil and recover the old behavior. > > We could remove most of those (if not all) uses of > `mouse-wheel-up/down/left/right-event`, but I don't think there's > a hurry to do that. Got it, thanks. > Admittedly, the ones in `completion-preview.el` could go because they're > new in Emacs-30 so there's no previous behavior to preserve. Indeed. I think I'll remove them then, that way we won't need to require mwheel in completion-preview.el anymore :)