From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Date: Thu, 27 Jun 2024 20:15:37 +0200 Message-ID: References: <865xtu7seh.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28983"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 71504@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 27 20:16:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMtfX-0007Kg-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jun 2024 20:16:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMtf7-0007bX-MR; Thu, 27 Jun 2024 14:16:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMtf6-0007bG-0r for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 14:16:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMtf5-0008FA-OU for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 14:15:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMtf8-0000ZM-HT for bug-gnu-emacs@gnu.org; Thu, 27 Jun 2024 14:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jun 2024 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71504 X-GNU-PR-Package: emacs Original-Received: via spool by 71504-submit@debbugs.gnu.org id=B71504.17195121482150 (code B ref 71504); Thu, 27 Jun 2024 18:16:02 +0000 Original-Received: (at 71504) by debbugs.gnu.org; 27 Jun 2024 18:15:48 +0000 Original-Received: from localhost ([127.0.0.1]:43336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMtet-0000Yc-PU for submit@debbugs.gnu.org; Thu, 27 Jun 2024 14:15:48 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:53330 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMteq-0000YQ-So for 71504@debbugs.gnu.org; Thu, 27 Jun 2024 14:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1719512140; bh=EOWYNk2DqvN7ie+NfLULfcLmTlQDSBFolLnRIzkDLJs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YatQyot39qeU5MD+GbwVkvFZaPDHkyulq5Z519EgX5nFtuZ6BRy/+/mJDgb/hYCy2 j8NICrxYSZKka4JV7Ar20K5vmKwJv8LbnuS4JMsiRxvBxC6tkGULbm16QSKcEbdNbz aaB2TM10FhrdDNIVP0wicsqNv2x1KMqVPUWp9JBMWgoO+913xGPyjhIcRgOMsf+2Z1 B+WQVuo4vKgRsxxeeUcL3rLl4FH76cFq3pTjWWt+2u9rKDCUXaoXXmLe82X6Fl1Wql GPFqouJYK8T/OwXoKmrKhUNfWPUASiH0hSAxE2N5eErZnUaSYWU2GOtdG/BPra1pdw yMVjINA8W8rFA== In-Reply-To: (Spencer Baugh's message of "Thu, 27 Jun 2024 09:35:34 -0400") X-Hashcash: 1:20:240627:eliz@gnu.org::8irOpG5Ler5C5W7E:0Cz3 X-Hashcash: 1:20:240627:71504@debbugs.gnu.org::05HMtpaAbHNveN8N:7Um4 X-Hashcash: 1:20:240627:sbaugh@janestreet.com::7+VG+g96Ns3daYhO:9RAK X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288032 Archived-At: Hi Spencer, Thanks for taking a look. Spencer Baugh writes: > Eli Zaretskii writes: >>> Date: Wed, 12 Jun 2024 10:43:14 +0200 >>> From: Eshel Yaron via "Bug reports for GNU Emacs, >>> the Swiss army knife of text editors" >>> >>> Following a recent short discussion[0] on emacs-devel, I'm opening this >>> feature request so it doesn't get lost: >>> >>> Flymake should provide a standard way for backends to associate fix >>> suggestions with the diagnostics they produce, along with a >>> backend-agnostic user interface (e.g. a command) for examining and >>> applying such fixes. >>> >>> I suggested a possible implementation that works quite well for me >>> (with the three backends I've adapted so far - checkdoc, shellcheck >>> and Eglot), but any other solution that gives various backends a >>> standard way to provide their fixes would be just as welcome. [...] > I also think we have not sufficiently explored different UI > possibilities, and I think adding to flymake now will limit us in what > UI possibilities we can explore, no matter how generic we try to be. > And that UI exploration can happen without adding to flymake. > > For example, maybe we want to have a command which can accept fixes > output by a process running in M-x compile. Baking the UI into flymake > would make that impossible, wouldn't it? I don't think adding a command for fixing the diagnostic at point should preclude any other developments or explorations. It's a useful thing to have, and many Flymake backends have the needed data readily available. > So before any change in flymake I would like to see much more > exploration of "fix" UIs which are genuinely flymake-independent. Flymake shows diagnostics, and "fixing" is what we do to diagnostics. What would be the benefit of a Flymake-independent UI for fixing the diagnostics that Flymake already shows? Eshel