From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: Filename completion for the 'file widget Date: 24 Aug 2004 22:31:48 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <412BD771.7010601@yahoo.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1093401146 3312 80.91.224.253 (25 Aug 2004 02:32:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Aug 2004 02:32:26 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 25 04:32:16 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BznaC-0000vz-00 for ; Wed, 25 Aug 2004 04:32:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bznej-0002nY-Nc for ged-emacs-devel@m.gmane.org; Tue, 24 Aug 2004 22:36:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1Bznec-0002nT-Td for emacs-devel@gnu.org; Tue, 24 Aug 2004 22:36:51 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1Bzneb-0002mu-Rw for emacs-devel@gnu.org; Tue, 24 Aug 2004 22:36:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bzneb-0002mr-Op for emacs-devel@gnu.org; Tue, 24 Aug 2004 22:36:49 -0400 Original-Received: from [206.47.199.164] (helo=simmts6-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BznZs-0003v8-8M for emacs-devel@gnu.org; Tue, 24 Aug 2004 22:31:56 -0400 Original-Received: from empanada.localhost ([67.71.35.111]) by simmts6-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20040825023136.BULE1635.simmts6-srv.bellnexxia.net@empanada.localhost>; Tue, 24 Aug 2004 22:31:36 -0400 Original-Received: by empanada.localhost (Postfix, from userid 502) id 5BE782AE22A; Tue, 24 Aug 2004 22:31:49 -0400 (EDT) Original-To: Kevin Rodgers In-Reply-To: <412BD771.7010601@yahoo.com> Original-Lines: 19 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26467 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26467 >> work on my local machine by using (concat directory completion) in place >> of (expand-file-name completion directory) in widget-file-complete. > That doesn't seem right. But I think it's the only good way. The normal completion coe uses `concat' as well. It should really be something like (concat (file-name-as-directory dir) completion) to be sure there's a / in there, and I would argue that it should be made into a function. Or maybe change expand-file-name such that you can do something like (expand-file-name file dir 'relativ)e to prevent `dir' from being made absolute. Many pieces of code use concat instead of expand-file-name. 90% of them should use expand-file-name instead, but the rest can't because it's important to keep the result non-absolute. I myself remember settling for `concat' in pcl-cvs, uniquify, and completion. Stefan