* bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
@ 2010-12-12 10:36 Leo
2010-12-13 17:10 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Leo @ 2010-12-12 10:36 UTC (permalink / raw)
To: 7619
There is a missing autoload to mark outline-heading-end-regexp safe
local while its doc string recommends setting it file locally. The
attached patch fixes this.
From 32fb65f511efab56e2ec926cbc49d2e324832909 Mon Sep 17 00:00:00 2001
Date: Sun, 12 Dec 2010 10:33:19 +0000
Subject: [PATCH] Mark outline-heading-end-regexp safe local
with predicate string-or-null-p.
---
lisp/outline.el | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/lisp/outline.el b/lisp/outline.el
index b5d3d79..37adb1e 100644
--- a/lisp/outline.el
+++ b/lisp/outline.el
@@ -62,6 +62,7 @@ The recommended way to set this is with a `Local Variables:' list
in the file it applies to."
:type 'regexp
:group 'outlines)
+;;;###autoload(put 'outline-heading-end-regexp 'safe-local-variable 'string-or-null-p)
(defvar outline-mode-prefix-map
(let ((map (make-sparse-keymap)))
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
2010-12-12 10:36 bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local Leo
@ 2010-12-13 17:10 ` Stefan Monnier
2010-12-19 7:26 ` Leo
2011-03-04 4:56 ` Glenn Morris
0 siblings, 2 replies; 6+ messages in thread
From: Stefan Monnier @ 2010-12-13 17:10 UTC (permalink / raw)
To: Leo; +Cc: 7619
> There is a missing autoload to mark outline-heading-end-regexp safe
> local while its doc string recommends setting it file locally. The
> attached patch fixes this.
Looks good, please apply it.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
2010-12-13 17:10 ` Stefan Monnier
@ 2010-12-19 7:26 ` Leo
2011-03-04 4:56 ` Glenn Morris
1 sibling, 0 replies; 6+ messages in thread
From: Leo @ 2010-12-19 7:26 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 7619
On 2010-12-13 17:10 +0000, Stefan Monnier wrote:
>> There is a missing autoload to mark outline-heading-end-regexp safe
>> local while its doc string recommends setting it file locally. The
>> attached patch fixes this.
>
> Looks good, please apply it.
>
>
> Stefan
I don't have commit access. Could someone help install it?
Thanks.
Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
2010-12-13 17:10 ` Stefan Monnier
2010-12-19 7:26 ` Leo
@ 2011-03-04 4:56 ` Glenn Morris
2011-03-04 5:32 ` Leo
1 sibling, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2011-03-04 4:56 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Leo, 7619
I was going to apply this, but then I noticed that nil is not an allowed
:type for outline-heading-end-regexp, so I don't see that
string-or-null-p is correct. But I also don't see why outline-regexp
does allow nil as a :type, when that is undocumented and will in fact
break several places in the code that assume it is a string.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
2011-03-04 4:56 ` Glenn Morris
@ 2011-03-04 5:32 ` Leo
2011-03-04 8:40 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Leo @ 2011-03-04 5:32 UTC (permalink / raw)
To: Glenn Morris; +Cc: 7619
On 2011-03-04 12:56 +0800, Glenn Morris wrote:
> I was going to apply this, but then I noticed that nil is not an allowed
> :type for outline-heading-end-regexp, so I don't see that
> string-or-null-p is correct. But I also don't see why outline-regexp
> does allow nil as a :type, when that is undocumented and will in fact
> break several places in the code that assume it is a string.
I think both cases should be changed to stringp.
Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local
2011-03-04 5:32 ` Leo
@ 2011-03-04 8:40 ` Glenn Morris
0 siblings, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2011-03-04 8:40 UTC (permalink / raw)
To: 7619-done
Version: 24.1
I figured out why nil was there. It's no longer relevant, so I removed
it and added the other safety predicate.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-04 8:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-12 10:36 bug#7619: 23.2.91; [PATCH] Mark outline-heading-end-regexp safe local Leo
2010-12-13 17:10 ` Stefan Monnier
2010-12-19 7:26 ` Leo
2011-03-04 4:56 ` Glenn Morris
2011-03-04 5:32 ` Leo
2011-03-04 8:40 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.