From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Date: Thu, 02 Sep 2021 23:22:17 +0200 Message-ID: References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34869"; mail-complaints-to="usenet@ciao.gmane.io" To: 50345@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 02 23:23:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mLuAz-0008m2-UX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 23:23:14 +0200 Original-Received: from localhost ([::1]:47450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLuAx-0003Bd-QC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Sep 2021 17:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLuAo-0003BU-3w for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 17:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58910) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLuAn-00046H-S6 for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 17:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mLuAn-00068A-Lt for bug-gnu-emacs@gnu.org; Thu, 02 Sep 2021 17:23:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Sep 2021 21:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163061774623508 (code B ref 50345); Thu, 02 Sep 2021 21:23:01 +0000 Original-Received: (at 50345) by debbugs.gnu.org; 2 Sep 2021 21:22:26 +0000 Original-Received: from localhost ([127.0.0.1]:42223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuAE-000676-3P for submit@debbugs.gnu.org; Thu, 02 Sep 2021 17:22:26 -0400 Original-Received: from out2.migadu.com ([188.165.223.204]:37063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mLuA9-00066v-BX for 50345@debbugs.gnu.org; Thu, 02 Sep 2021 17:22:24 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630617739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=pAVB/qSrko3KsJaAp7PfupN471xb8AtFcaXYhV6cVJw=; b=jljuqLSCGxeSKVykE+gP5Wr1nXxDG8odRxny5sH15FhsCqNyVi9dmxVJ4UTCdvsnZ2d2kA aABWw7dHka23Pz2f7yx1ySfSD1PDsMDxXw36x6Jy+wopaojOIvs2szC0S/ZPtwUT9Yd7BP Aoitl4rSXbPv9o2xE4la0knLGanyQr9vAyo4PnTTqCJHQ4NxD5zwiLkgiY6TVJ/zea/6mv 1a9gD0gEx1uTv80K4b/HBImEosYtcyo4cKrDTROcEVOreNxf8lrpkO8IXuA5WyfQVHIIx7 RWIqykjcpXM5TbtLMDc23pxZo+2nC5k23xZHxSBD4ojD68Nl4ZQLmbq/d1wqVQ== X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213304 Archived-At: --=-=-= Content-Type: text/plain Hi again! I took the liberty to add the keywords from [0]. I moved the justify and align parts out from the flex block and into its own block. I also took the liberty to add the `place' variants as well. These are used a lot when using grid to set up your web page. I hope this is usable. I see that some properties are extracted out into variables, but not sure what is standard practice here. Good evening, Theodor [0]: https://www.w3.org/TR/css-align-3 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-CSS-Box-Alignment-Module-Level-3-to-css-mode.patch >From dccf92224cbe37805ae53edb49be4c098df47d0c Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Thu, 2 Sep 2021 23:13:02 +0200 Subject: [PATCH] Add CSS Box Alignment Module Level 3 to css-mode * lisp/textmodes/css-mode.el (css-property-alist): Consolidate `align-{contents, items, self}', as well as the corresponding values for `justify-{contents, items, self}' and `place-{contents, items, self}'. Values extracted from the flex part and into its own block. --- lisp/textmodes/css-mode.el | 38 ++++++++++++++++++++++++++++++-------- 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 3bcd9c9766..f406afb7b6 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -301,14 +301,38 @@ ("grid-template-columns" "none" track-list auto-track-list) ("grid-template-rows" "none" track-list auto-track-list) + ;; CSS Box Alignment Module Level 3 + ;; (https://www.w3.org/TR/css-align-3/#alignment-values) + ("align-content" "center" "start" "end" "flex-start" "flex-end" + "normal" "first" "last" "baseline" "space-between" "space-around" + "space-evenly" "stretch" "safe" "unsafe") + ("align-items" "normal" "stretch" "center" "start" "end" + "flex-start" "flex-end" "baseline" "first" "last" "baseline" + "safe" "unsafe") + ("align-self" "auto" "normal" "center" "start" "end" + "self-start" "self-end" "flex-start" "flex-end" + "baseline" "first" "last" "stretch" "safe" "unsafe") + ("justify-content" "center" "start" "end" "flex-start" "flex-end" + "left" "right" "normal" "space-between" "space-around" + "space-evenly" "stretch" "safe" "unsafe") + ("justify-items" "auto" "normal" "stretch" "center" "start" "end" + "flex-start" "flex-end" "self-start" "self-end" "left" "right" + "baseline" "first" "last" "legacy" "safe" "unsafe") + ("justify-self" "auto" "normal" "stretch" "center" "start" "end" + "flex-start" "flex-end" "self-start" "self-end" "left" "right" + "baseline" "first" "last" "safe" "unsafe") + ("place-content" "center" "start" "end" "left" "right" "flex-start" + "flex-end" "baseline" "first" "last" "space-evenly" "space-around" + "space-between") + ("place-items" "auto" "normal" "center" "start" "end" + "self-start" "self-end" "flex-start" "flex-end" + "left" "right" "baseline" "first" "last" "stretch") + ("place-self" "auto" "center" "start" "end" "self-start" "self-end" + "flex-start" "flex-end" "normal" "left" "right" "baseline" + "first" "last" "stretch") + ;; CSS Flexible Box Layout Module Level 1 ;; (https://www.w3.org/TR/css-flexbox-1/#property-index) - ("align-content" "flex-start" "flex-end" "center" "space-between" - "space-around" "stretch") - ("align-items" "flex-start" "flex-end" "center" "baseline" - "stretch") - ("align-self" "auto" "flex-start" "flex-end" "center" "baseline" - "stretch") ("flex" "none" flex-grow flex-shrink flex-basis) ("flex-basis" "auto" "content" width) ("flex-direction" "row" "row-reverse" "column" "column-reverse") @@ -316,8 +340,6 @@ ("flex-grow" number) ("flex-shrink" number) ("flex-wrap" "nowrap" "wrap" "wrap-reverse") - ("justify-content" "flex-start" "flex-end" "center" - "space-between" "space-around") ("order" integer) ;; CSS Fonts Module Level 3 -- 2.30.1 (Apple Git-130) --=-=-=--