From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65854: Multi-file replacement diff Date: Fri, 15 Sep 2023 09:02:55 +0200 Message-ID: References: <86sf7mgd54.fsf@mail.linkov.net> <86bke943tp.fsf@mail.linkov.net> <83jzswrios.fsf@gnu.org> <86o7i7oo9t.fsf@mail.linkov.net> <86sf7g548a.fsf@mail.linkov.net> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7751"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 65854@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 09:04:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh2sI-0001mi-Pr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 09:04:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh2rv-0006Z3-Kh; Fri, 15 Sep 2023 03:03:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh2ru-0006Yg-F5 for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:03:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh2rr-0001R3-KO for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:03:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh2rx-0006Dq-N2 for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 03:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 07:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65854 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65854-submit@debbugs.gnu.org id=B65854.169476138923857 (code B ref 65854); Fri, 15 Sep 2023 07:04:01 +0000 Original-Received: (at 65854) by debbugs.gnu.org; 15 Sep 2023 07:03:09 +0000 Original-Received: from localhost ([127.0.0.1]:41911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh2r7-0006Ci-3g for submit@debbugs.gnu.org; Fri, 15 Sep 2023 03:03:09 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:58060 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh2r3-0006CY-A6 for 65854@debbugs.gnu.org; Fri, 15 Sep 2023 03:03:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1694761378; bh=51QncFo91TLcdFOWfTGjBzjJ8dS8m3dZvwAVaCeg+qU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=E++lUUXB8PDWBv/MC0OBS+woqvAVlNV/fFqNfip5JQdyS2K4ZJSS6eMTEO5vyz4ES WbuPG9nYiqeBDZVkFjlD+wIAFWF7/GIDhfXWwXeKEVQ4Vr11UeOlWGe2QfjPSKeAEW wFdoZAP3V/U8GUo5Mgz2Himlpgl8NXS9iBkdZ5VKJhsKKlQyzAr1WiQeSk9rluefoO g615293EgQLNTEauVC6mtv4QweHHtm/ygpJM2Y1QKHviKNKfhrKzrh+5ZvGdk3WwLr atUkyEd0S4G1uxqKuFmAamMq6lUVaTvM1FOMty4enoz1UCqI869uQM5D5TPj00G91I 85fTpnL5imU6A== In-Reply-To: <86sf7g548a.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 15 Sep 2023 09:40:21 +0300") X-Hashcash: 1:20:230915:juri@linkov.net::fDONZvwZq2EMDdJp:094k X-Hashcash: 1:20:230915:eliz@gnu.org::ko371C5XcruTxXw2:3HBt X-Hashcash: 1:20:230915:65854@debbugs.gnu.org::NHoZajfUuiCgNqkw:BEMK X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270498 Archived-At: Juri Linkov writes: > > Here is a new customizable option 'multi-file-diff-unsaved' > that defines what to do with unsaved changes. When it is > 'use-buffer' then it handles the case Eshel demonstrated > where changes are applied over unsaved buffers. But when > the value is 'save-buffers', then 'save-some-buffers' is > called before producing the diff. > Nice! One thought about the default choice: > +(defcustom multi-file-diff-unsaved 'use-file I wonder if it wouldn't be better to use save-buffers by default, ISTM that it's the "least surprising" choice. Cheers, Eshel