From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master e720ba62193 1/2: (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events Date: Tue, 09 Apr 2024 19:29:39 +0200 Message-ID: References: <171267304154.21960.14298364323940508129@vcs2.savannah.gnu.org> <20240409143042.278CDC12C36@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12385"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 09 19:30:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruFIy-0002xM-DM for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Apr 2024 19:30:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruFI6-0000aP-UB; Tue, 09 Apr 2024 13:29:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruFI5-0000aF-T9 for emacs-devel@gnu.org; Tue, 09 Apr 2024 13:29:49 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruFI2-0008Ai-ML for emacs-devel@gnu.org; Tue, 09 Apr 2024 13:29:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1712683782; bh=bDI7LeU2f3eAh1lyyUwhbY8GBMyzIzd2BuHHuqCf5lU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=OuZ2NvQ5o9R3BdyL6s5R3MuObiczaoyhv+GtlvENYl4QHz9NpKjAELQ4+vPzBMjTw zjRWb/fD21/2A36Ch1fLSrykNPT4X1/HrHBe/njXiSVRyGSjjV/WGhaoWPK4u0Z6gc LWFSE5s8CZCaAdIdxLGAh/5LzCaH2tytBu9Y2brP8MUP6aswlB4XdBQcS+uAmw2U7Y TCO7DHd6KRTHwBQLTNvB44a15NtnwLN8lbF7BWNNEYi3JN0rdipB0WtR48NJmVdIyI 4EtHxxqKnZqTJjm26DEPu8mKHv/hQVnEtpDL8ovQZDl7rFnLtz/FiMSf1VqDKC3+2A PFYphYaazKoCg== In-Reply-To: <20240409143042.278CDC12C36@vcs2.savannah.gnu.org> (Stefan Monnier via Mailing list for Emacs changes's message of "Tue, 9 Apr 2024 10:30:41 -0400 (EDT)") X-Hashcash: 1:20:240409:emacs-devel@gnu.org::DihMhlVPht3X5PI6:1Jy9 X-Hashcash: 1:20:240409:monnier@iro.umontreal.ca::7SuEQeLdi/y+D9GV:0Y6q Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317647 Archived-At: Hi Stefan, Stefan Monnier writes: > branch: master > commit e720ba6219394d275dd741c5f17feea1ee0bf9af > Author: Stefan Monnier > Commit: Stefan Monnier > > (mouse-wheel-buttons): Map old-style wheel buttons to actual wheel events > > Change the handling of the old X11 convention that uses mouse-4/5/6/7 > events to represent wheel events: instead of asking downstream > packages to use the `mouse-wheel-*-event` variables to know which events > represent wheel events, use new var `mouse-wheel-buttons` to directly > convert those events into the standard `wheel-up/down/left/right` events > used everywhere else. > > This will simplify the work of packages which can thus just bind their > commands to `wheel-up/down/left/right`. [...] > diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el > index a86c1ba1cc9..a1e0abe2e14 100644 > --- a/lisp/completion-preview.el > +++ b/lisp/completion-preview.el > @@ -139,9 +139,13 @@ If this option is nil, these commands do not display any message." > ;; and vice versa!! > "" #'completion-preview-prev-candidate > "" #'completion-preview-next-candidate > - (key-description (vector mouse-wheel-up-event)) > + (key-description (with-suppressed-warnings > + ((obsolete mouse-wheel-up-event)) > + (vector mouse-wheel-up-event))) > #'completion-preview-next-candidate > - (key-description (vector mouse-wheel-down-event)) > + (key-description (with-suppressed-warnings > + ((obsolete mouse-wheel-down-event)) > + (vector mouse-wheel-down-event))) > #'completion-preview-prev-candidate) I wonder whether/why we should keep the bindings that use mouse-wheel-up/down-event here. Do I understand correctly that since we already bind wheel-down/up directly, we should now be able to simply remove these additional bindings? Thanks, Eshel