bug#14681: [gmane.emacs.devel] random 1 second delay in comint-redirect-results-list-from-process

bug#14681: [gmane.emacs.devel] random 1 second delay in comint-redirect-results-list-from-process

[Leo Liu]

[-- Attachment #1: Type: message/rfc822, Size: 360 bytes --]

Subject: Topics

Topics:
   random 1 second delay in comint-redirect-results-list-from-process
   Re: random 1 second delay in comint-redirect-results-list-from-process
   Re: random 1 second delay in comint-redirect-results-list-from-process
   Re: random 1 second delay in comint-redirect-results-list-from-process

[-- Attachment #2: Type: message/rfc822, Size: 543 bytes --]

From: Leo Liu <sdl.web@gmail.com>
To: emacs-devel@gnu.org
Subject: random 1 second delay in comint-redirect-results-list-from-process
Date: Thu, 20 Jun 2013 08:06:26 +0800
Message-ID: <m1ip19odbx.fsf@gmail.com>

Hi there,

I am seeing seemingly random delay of 1 second when using
comint-redirect-results-list-from-process, which may be the fault of
(accept-process-output nil 1).

Could someone explain (accept-process-output nil 1)? Any harm in
reducing it to (accept-process-output nil)?

Leo





[-- Attachment #3: Type: message/rfc822, Size: 542 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: random 1 second delay in comint-redirect-results-list-from-process
Date: Wed, 19 Jun 2013 22:16:12 -0400
Message-ID: <jwvzjulil2c.fsf-monnier+emacs@gnu.org>

> Could someone explain (accept-process-output nil 1)? Any harm in
> reducing it to (accept-process-output nil)?

Rather than nil it should pass the actual process.


        Stefan




[-- Attachment #4: Type: message/rfc822, Size: 996 bytes --]

From: Leo Liu <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: random 1 second delay in comint-redirect-results-list-from-process
Date: Thu, 20 Jun 2013 16:04:54 +0800
Message-ID: <m1fvwdxl5l.fsf@gmail.com>

On 2013-06-20 10:16 +0800, Stefan Monnier wrote:
> Rather than nil it should pass the actual process.

Is it OK to apply the following patch?

=== modified file 'lisp/comint.el'
--- lisp/comint.el      2013-05-25 02:40:33 +0000
+++ lisp/comint.el      2013-06-20 05:14:25 +0000
@@ -3726,7 +3726,7 @@
       ;; Wait for the process to complete
       (set-buffer (process-buffer process))
       (while (null comint-redirect-completed)
-       (accept-process-output nil 1))
+       (accept-process-output process))
       ;; Collect the output
       (set-buffer output-buffer)
       (goto-char (point-min))




[-- Attachment #5: Type: message/rfc822, Size: 734 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: random 1 second delay in comint-redirect-results-list-from-process
Date: Thu, 20 Jun 2013 16:17:14 -0400
Message-ID: <jwvehbwh71t.fsf-monnier+emacs@gnu.org>

>        (while (null comint-redirect-completed)
> -       (accept-process-output nil 1))
> +       (accept-process-output process))

I think it's OK, tho I think the loop should of course check the return
value of accept-process-output (or else, check that the process is
still running).


        Stefan

bug#14681: [gmane.emacs.devel] random 1 second delay in comint-redirect-results-list-from-process

[Leo Liu]

Fixed in trunk.