From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r114523: * progmodes/octave.el (inferior-octave-mode): Call Date: Sat, 05 Oct 2013 10:43:09 +0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380941011 9363 80.91.229.3 (5 Oct 2013 02:43:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Oct 2013 02:43:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 05 04:43:34 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VSHqA-0007UJ-L5 for ged-emacs-devel@m.gmane.org; Sat, 05 Oct 2013 04:43:34 +0200 Original-Received: from localhost ([::1]:50420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSHqA-0001mC-2g for ged-emacs-devel@m.gmane.org; Fri, 04 Oct 2013 22:43:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSHpz-0001ja-Is for emacs-devel@gnu.org; Fri, 04 Oct 2013 22:43:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSHpr-0006kY-3o for emacs-devel@gnu.org; Fri, 04 Oct 2013 22:43:23 -0400 Original-Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:42454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSHpq-0006kR-Sr for emacs-devel@gnu.org; Fri, 04 Oct 2013 22:43:15 -0400 Original-Received: by mail-pd0-f173.google.com with SMTP id p10so4773703pdj.18 for ; Fri, 04 Oct 2013 19:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=KxA+4HLuH64/x7Nt6FOOOxQNOi2kYA1Kmqxd+n/G21c=; b=fhWkEnkxSN3c9+Bfl8UG0sj2sg+N+EDg8tvRLIG+WwmYVGGV+ZCirWtKd5it5oqFWP WJDJfr9R4WvERw6LsF2qPJJPJY2vGbKYQEz72u5kqwfC02c4FfxvZA4LyeTMPbvP2q8a gFhZfVGyHV0vrFgV7hxhpL2wrKbOYTkB9dkY8gMHc3e4aFaJGgWf9IMzzRhLKjiJQT2B XeGQRzFtL+rfqvA4Q7QvgxMvdOa4g6uaqKQgm2FBaBXX7wabucF/FcvyeXjd5tVf9EFw 25aqRk0EBxPIKzzFBWkanoa/QhY0KilGdiGtLldzUUT5wHnNeakg4WDimmOAAntgoWKR Czxw== X-Received: by 10.68.197.36 with SMTP id ir4mr17723946pbc.96.1380940993559; Fri, 04 Oct 2013 19:43:13 -0700 (PDT) Original-Received: from localhost ([222.131.216.43]) by mx.google.com with ESMTPSA id so2sm17891119pbc.5.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 04 Oct 2013 19:43:12 -0700 (PDT) Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC In-Reply-To: (Stefan Monnier's message of "Fri, 04 Oct 2013 13:53:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.5) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c02::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163867 Archived-At: On 2013-10-05 01:53 +0800, Stefan Monnier wrote: > This call doesn't seem very useful: at that point in time, there aren't > any errors parsed yet anyway. The intention of the change I made is to make C-x ` go to the errors by latest run-octave instead of past run-octave, i.e. one can M-x run-octave multiple times in the same buffer. Is this useful? > The need for compilation-forget-errors is because in a comint-buffer, > you can have error "foo:3:Syntax error" appear many times following > different commands loading different versions of "foo" (e.g. because it > was edited in the mean time). So you need to call > compilation-forget-errors whenever you know that the underlying process > will look at "files that have been modified". It's often difficult to > know "the right place" where it should be called, but typically > -send-region, and related functions are good spots. I am not entirely sure but I have put in a call to compilation-forget-errors in octave-send-region just like prolog-old-process-file for example. Hope this makes sense. Leo