all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Liu <sdl.web@gmail.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] trunk r114523: * progmodes/octave.el (inferior-octave-mode): Call
Date: Sat, 05 Oct 2013 10:43:09 +0800	[thread overview]
Message-ID: <m1a9io5tfm.fsf@gmail.com> (raw)
In-Reply-To: <jwvsiwhrkos.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Fri, 04 Oct 2013 13:53:10 -0400")

On 2013-10-05 01:53 +0800, Stefan Monnier wrote:
> This call doesn't seem very useful: at that point in time, there aren't
> any errors parsed yet anyway.

The intention of the change I made is to make C-x ` go to the errors by
latest run-octave instead of past run-octave, i.e. one can M-x
run-octave multiple times in the same buffer. Is this useful?

> The need for compilation-forget-errors is because in a comint-buffer,
> you can have error "foo:3:Syntax error" appear many times following
> different commands loading different versions of "foo" (e.g. because it
> was edited in the mean time).  So you need to call
> compilation-forget-errors whenever you know that the underlying process
> will look at "files that have been modified".  It's often difficult to
> know "the right place" where it should be called, but typically
> <foo>-send-region, and related functions are good spots.

I am not entirely sure but I have put in a call to
compilation-forget-errors in octave-send-region just like
prolog-old-process-file for example. Hope this makes sense.

Leo



  reply	other threads:[~2013-10-05  2:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1VS73s-0003ZU-3o@vcs.savannah.gnu.org>
2013-10-04 17:53 ` [Emacs-diffs] trunk r114523: * progmodes/octave.el (inferior-octave-mode): Call Stefan Monnier
2013-10-05  2:43   ` Leo Liu [this message]
2013-10-05 18:39     ` Stefan Monnier
2013-10-05 18:41     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1a9io5tfm.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.