From: Leo Liu <sdl.web@gmail.com>
To: 15746@debbugs.gnu.org
Cc: Karl Fogel <kfogel@red-bean.com>
Subject: bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite
Date: Tue, 29 Oct 2013 11:32:58 +0800 [thread overview]
Message-ID: <m1a9hsrbth.fsf@gmail.com> (raw)
Occationally I have overwritten bookmarks with regrets. So maybe
something along the following lines is needed.
=== modified file 'lisp/bookmark.el'
--- lisp/bookmark.el 2013-09-11 03:31:56 +0000
+++ lisp/bookmark.el 2013-10-29 03:27:15 +0000
@@ -811,6 +811,12 @@
bookmark-minibuffer-read-name-map
nil nil defaults))))
(and (string-equal str "") (setq str default))
+ (when (and (not no-overwrite)
+ (bookmark-get-bookmark str)
+ (called-interactively-p 'interactive)
+ (not (yes-or-no-p
+ (format "Bookmark `%s' exists; overwrite? " str))))
+ (user-error "Aborted"))
(bookmark-store str (cdr record) no-overwrite)
;; Ask for an annotation buffer for this bookmark
next reply other threads:[~2013-10-29 3:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 3:32 Leo Liu [this message]
2013-10-29 14:20 ` bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Drew Adams
2013-10-29 18:24 ` Karl Fogel
2013-10-29 20:09 ` Drew Adams
2013-10-29 20:51 ` Karl Fogel
2013-10-29 22:16 ` Drew Adams
2013-10-30 4:31 ` Karl Fogel
2013-10-30 14:07 ` Drew Adams
2013-10-30 2:11 ` Stefan Monnier
2013-10-30 2:35 ` Drew Adams
2013-10-30 2:56 ` Leo Liu
2013-10-30 3:14 ` Stefan Monnier
2013-10-30 3:36 ` Leo Liu
2013-10-30 3:57 ` Stefan Monnier
2013-10-30 14:07 ` Drew Adams
2013-10-30 18:17 ` Stefan Monnier
2013-10-30 1:28 ` Leo Liu
2013-10-30 2:26 ` Drew Adams
2015-11-08 19:27 ` bug#15746: Fix committed to master Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1a9hsrbth.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=15746@debbugs.gnu.org \
--cc=kfogel@red-bean.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.