From: joaotavora@gmail.com (João Távora)
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: electric-pair-mode as a minor mode?
Date: Sun, 26 Apr 2015 11:28:36 +0100 [thread overview]
Message-ID: <m1a8xvxjxn.fsf@holy.lan> (raw)
In-Reply-To: <m338416p9y.fsf@gnus.org> (Lars Magne Ingebrigtsen's message of "Wed, 15 Apr 2015 23:43:37 +0200")
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> On a related subject, I was thinking of (require 'smiley) in message.el
>> to avoid a `message-smiley' variable (a list o strings), and just use
>> the cars of `smiley-regexp-alist'. Can that be problematic?
> Requiring smiley should be unproblematic, I think.
Not so, unfortunately. Requiring it eventually requires `message'
recursively. I tried with `eval-when-compile'. It works when compiling
message.el standalone, but not when making emacs (some interaction with
eager-macroexpansion, apparently):
How do I solve this?
João
PS: Here's what I tried:
diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index 1371e70..fe2097e 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -2964,15 +2964,13 @@ See also `message-forbidden-properties'."
(autoload 'ecomplete-setup "ecomplete") ;; for Emacs <23.
-(defvar message-smileys '(":-)" ":)"
- ":-(" ":("
- ";-)" ";)")
- "A list of recognized smiley faces in `message-mode'.")
+(eval-when-compile (require 'smiley)) ;; for `smiley-regexp-alist,'
+ ;; `eval-when-compile' needed to
+ ;; prevent recursive require.
(defun message--syntax-propertize (beg end)
"Syntax-propertize certain message text specially."
- (let ((citation-regexp (concat "^" message-cite-prefix-regexp ".*$"))
- (smiley-regexp (regexp-opt message-smileys)))
+ (let ((citation-regexp (concat "^" message-cite-prefix-regexp ".*$")))
(goto-char beg)
(while (search-forward-regexp citation-regexp
end 'noerror)
@@ -2982,11 +2980,14 @@ See also `message-forbidden-properties'."
`(syntax-table ,(string-to-syntax "<")))
(add-text-properties end (min (1+ end) (point-max))
`(syntax-table ,(string-to-syntax ">")))))
- (goto-char beg)
- (while (search-forward-regexp smiley-regexp
- end 'noerror)
- (add-text-properties (match-beginning 0) (match-end 0)
- `(syntax-table ,(string-to-syntax "."))))))
+ (when (featurep 'smiley)
+ (mapc (lambda (smiley-regexp)
+ (goto-char beg)
+ (while (search-forward-regexp smiley-regexp
+ end 'noerror)
+ (add-text-properties (match-beginning 0) (match-end 0)
+ `(syntax-table ,(string-to-syntax ".")))))
+ (mapcar #'car smiley-regexp-alist)))))
;;;###autoload
(define-derived-mode message-mode text-mode "Message"
next prev parent reply other threads:[~2015-04-26 10:28 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 19:51 electric-pair-mode as a minor mode? Yuri D'Elia
2015-03-27 2:18 ` Stefan Monnier
2015-03-27 8:04 ` Yuri D'Elia
2015-03-27 13:19 ` Stefan Monnier
2015-03-27 11:18 ` João Távora
2015-03-27 13:25 ` Stefan Monnier
2015-03-27 14:09 ` João Távora
2015-03-27 18:20 ` Stefan Monnier
2015-03-28 16:11 ` João Távora
2015-03-28 20:36 ` Stefan Monnier
2015-03-28 21:47 ` João Távora
2015-03-28 23:09 ` João Távora
2015-03-29 4:01 ` Stefan Monnier
2015-03-29 20:41 ` João Távora
2015-03-30 0:54 ` Stefan Monnier
2015-03-30 10:46 ` João Távora
2015-03-30 13:53 ` Stefan Monnier
2015-03-30 15:43 ` João Távora
2015-03-30 20:33 ` Stefan Monnier
2015-03-30 20:42 ` João Távora
2015-03-30 21:47 ` João Távora
2015-03-30 22:02 ` Stefan Monnier
2015-04-11 16:06 ` João Távora
2015-04-12 11:56 ` Stefan Monnier
2015-04-12 13:16 ` João Távora
2015-04-12 16:39 ` Dmitry Gutov
2015-04-12 22:16 ` João Távora
2015-04-12 23:10 ` Dmitry Gutov
2015-04-15 21:32 ` João Távora
2015-04-15 13:59 ` Lars Magne Ingebrigtsen
2015-04-15 21:16 ` João Távora
2015-04-15 21:21 ` Lars Magne Ingebrigtsen
2015-04-15 21:39 ` João Távora
2015-04-15 21:43 ` Lars Magne Ingebrigtsen
2015-04-26 10:28 ` João Távora [this message]
2015-04-26 19:48 ` Lars Magne Ingebrigtsen
2015-04-27 2:29 ` Stefan Monnier
2015-03-27 19:38 ` Yuri D'Elia
2015-03-27 12:52 ` Tom Willemse
2015-03-27 19:01 ` Stefan Monnier
2015-03-28 15:47 ` bug#19528: " João Távora
2015-03-28 15:47 ` João Távora
2015-03-28 17:37 ` bug#19528: " Glenn Morris
2015-03-28 21:01 ` João Távora
2015-04-14 6:28 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1a8xvxjxn.fsf@holy.lan \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.