Re: Word completion in text modes

[Eshel Yaron <me@eshelyaron.com>]

Eli Zaretskii <eliz@gnu.org> writes:

>> It _is_ bound to `C-M-i` in `text-mode`, that's actually even mentioned
>> in several places in the Emacs manual, e.g. in "(emacs) Text Mode":
>>
>>     Text mode binds ‘M-<TAB>’ to ‘ispell-complete-word’.
>
> I tried that in mail-mode and didn't see it bound.  But that's because
> mail-mode binds C-M-i to another command.  Which IMO is a sign of a
> problem we need to fix: it makes no sense to have a completion command
> bound in Text mode but not in _all_ of its descendants.

Yes, `C-M-i` is bound to `completion-at-point` in `mail-mode-map`, which
is exactly the binding I'm proposing for the parent, `text-mode`, no?

> I guess the developers of mail-mode didn't consider
> ispell-complete-word an important enough feature, and the question
> then becomes: will the new text-mode completion-at-point feature be
> significantly better?
>
> In any case, back to the original issue: what you say about rebinding
> ispell-complete-word can only be a problem if the new completion is
> incompatible with ispell-complete-word.  So we should make sure it is
> NOT incompatible.  Then the problem would not exist.

The way I see it `ispell-complete-word` predates `completion-at-point`,
and in terms of functionality the latter subsumes the former.
`ispell-complete-word` reuses the spell correction UI of `ispell-word`
for word completion.  That's something that I wouldn't necessarily try
to port over to `completion-at-point` for compatibility sake, as we now
have various proper completion (not spell correction) interfaces that
were not available when `ispell-complete-word` came about.  Either way
it'd be compatible in the sense that you get the same completions, and
`ispell-complete-word` wouldn't go anywhere so users could rebind it if
they really want to.

>> > IMNSHO, such a feature would be much more important and useful than
>> > the minor changes of UI and reshuffling of the implementation details
>> > of the sort that you propose.
>>
>> My proposal would benefit this aim as well, I think, as we could simply
>> add another completion function to `completion-at-point-functions`, say
>> `phrase-completion-at-point`, and users would have their word completion
>> extended to include such phrase completion with no further setup.
>
> I appreciate the enthusiasm, but very much doubt that minor internal
> changes ("minor" from the POV of user-visible changes in behavior)
> will eventually bring us important features such as powerful text-mode
> completion.  Infrastructure that makes extensions easy is a Good
> Thing, but it is not enough to actually make those extensions happen,
> not by a long shot.

Absolutely, there's some more work to be done to accomplish what you
describe, no magic solutions here.  I propose to modernize completion in
text modes, opening a door for further developments.

> Which is why I prefer to make such internal reshuffling only together
> with installing the corresponding extensions, not as separate
> "cleanups".

Alright, although IMO this has concrete benefits beyond mere cleanup.
I'm fine with keeping this patch in a local branch for now, of course.

>> My concern here regards users that are used to pressing `C-M-i` in
>> `text-mode` and friends, and getting `ispell-complete-word`.  If we
>> follow my suggestion of removing this binding, `C-M-i` would invoke
>> `completion-at-point`, providing similar functionality but with a
>> different interface (by default that would be the *Completions*
>> buffer, instead of the *Choices* buffer that `ispell-complete-word`
>> provides).
>
> If that is the danger, it follows that we should make the UI of
> completion-at-point be able to support the UI of ispell-complete-word.

Sure, we could also add a `completion-in-region-function` that imitates
the current UI of `ispell-complete-word`, although IMO it's not really
an ideal interface for completions, so I'm not sure users would like
that for the rest of their `completion-at-point` calls.  That could be
made local in text mode buffers, perhaps.

> Btw, reusing the *Completions* buffer might cause problems on its own,
> regardless of the ispell-complete-word issue: what if this completion
> is invoked while typing at the prompt of a command that already popped
> up the *Completions* buffer?

That's interesting.  I guess Emacs could keep a stack of such nested
completion sessions and restore the first session when the other ends.
I'm not sure if there's something of that sorts in place.  Indeed,
that's a broader issue than the one at hand.

> Something to think about, I guess, if we are going to add more and
> more of these completion-at-point frameworks and features.


Thanks,

Eshel