From: "Greg A. Woods" <woods@robohack.ca>
To: 20539@debbugs.gnu.org
Subject: bug#20539: 24.5; magit-auto-revert-mode broken by 24.5 upgrade with change to behaviour of `let`
Date: Sat, 09 May 2015 15:26:55 -0700 [thread overview]
Message-ID: <m1YrDCx-0037iFC@more.local> (raw)
In-Reply-To: <m1YrBBV-0037iFC@more.local>
So, it appears I (and perhaps edbug) was confused between the function
`auto-revert-mode' and the variable of the same name! I should know
better!
So the problem is more likely just that `auto-revert-handler' is not
behaving quite the same way in 24.5 as it did before, specifically with
respect to the value of the `auto-revert-mode' variable. Since it is
explicitly marked as an internal function I retract my suggestion that
the change is in any way a major bug in 24.5.
My proposed fix is no doubt wrong too as I think it will just force
auto-revert-mode on for each buffer it tries to revert.
I've reported the issue to the magit maintainers on github and hopefully
someone can find a suitable work-around, though perhaps the real fix will
involve enhancing autorevert to make it more amenable to non-interactive
interaction with other modules.
For my own use I think my hack works anyway because I think I do always
want auto-revert-mode for all buffers visiting files in any repository
I'm working in.
Sorry for any confusion w.r.t. `let'!
--
Greg A. Woods
+1 250 762-7675 RoboHack <woods@robohack.ca>
Planix, Inc. <woods@planix.com> Secrets of the Weird <woods@weird.com>
next prev parent reply other threads:[~2015-05-09 22:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-09 20:17 bug#20539: 24.5; magit-auto-revert-mode broken by 24.5 upgrade with change to behaviour of `let` Greg A. Woods
2015-05-09 22:26 ` Greg A. Woods [this message]
2017-12-08 1:43 ` Noam Postavsky
2015-05-11 2:33 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1YrDCx-0037iFC@more.local \
--to=woods@robohack.ca \
--cc=20539@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.