desktop.el not playing nice

desktop.el not playing nice

[Stephan Stahl]

Hi.

I found that info/emacs-5 is not totaly clear about desktop.el

Currently is says:

----------
   You can save the desktop manually with the command `M-x
desktop-save'.  You can also enable automatic desktop saving when you
exit Emacs: use the Customization buffer (*note Easy Customization::)
to set `desktop-save-mode' to `t' for future sessions, or add this line
in your `~/.emacs' file:

     (desktop-save-mode 1)

   When Emacs starts, it looks for a saved desktop in the current
directory.  Thus, you can have separate saved desktops in different
directories, and the starting directory determines which one Emacs
reloads.  You can save the current desktop and reload one saved in
another directory by typing `M-x desktop-change-dir'.  Typing `M-x
desktop-revert' reverts to the desktop previously reloaded.

   Specify the option `--no-desktop' on the command line when you don't
want it to reload any saved desktop.
----------

Emacs only loads the saved desktop on startup when

(desktop-save-mode 1)

is in .emacs.  Or desktop.el is loaded somehow before after-init-hook
is run.

When that is the case and i start emacs with --no-desktop it seems
clear to me that i do not want to USE or ALTER the saved desktop.
However when i try to exit emacs i get asked where the desktop file
should be saved.  I can not exit emacs without this step unless i
disable desktop-save-mode.  This seems wrong to me because i said
--no-desktop and saving could overwrite my old desktop file.  I work
around this by starting

emacs --no-desktop --eval "(customize-set-variable 'desktop-enable nil)"

but this seems like a pitfall for emacs starters.  Maybe --no-desktop
should disable desktop-save-mode?

What do others think?
-- 
Stephan Stahl

Re: desktop.el not playing nice

[David Kastrup]

"Stephan Stahl" <stahl@eos.franken.de> writes:

> --no-desktop and saving could overwrite my old desktop file.  I work
> around this by starting
>
> emacs --no-desktop --eval "(customize-set-variable 'desktop-enable
> nil)"
>
> but this seems like a pitfall for emacs starters.  Maybe
> --no-desktop should disable desktop-save-mode?
>
> What do others think?

Sounds like a no-brainer.  Seconded.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: desktop.el not playing nice

[Robert J. Chassell]

Stephan Stahl asks

   Maybe --no-desktop should disable desktop-save-mode?

Yes.  I have run into the same problem:  when I start an instance of
Emacs with --no-desktop, I want neither to use nor to alter my saved
desktop.  I want that instance of Emacs to ignore my ~/.emacs.desktop
file entirely.

But when I start a regular instance of Emacs, I do want to be able to
load my saved desktop.

-- 
    Robert J. Chassell                         
    bob@rattlesnake.com                         GnuPG Key ID: 004B4AC8
    http://www.rattlesnake.com                  http://www.teak.cc

Re: desktop.el not playing nice

[Richard Stallman]

Does this patch give results you like?

*** desktop.el	05 Apr 2005 15:08:34 -0400	1.82
--- desktop.el	18 Apr 2005 01:22:51 -0400	
***************
*** 1031,1037 ****
    '(lambda ()
      (let ((key "--no-desktop"))
        (if (member key command-line-args)
!         (delete key command-line-args)
          (when desktop-save-mode (desktop-read))))))
  
  (provide 'desktop)
--- 1031,1039 ----
    '(lambda ()
      (let ((key "--no-desktop"))
        (if (member key command-line-args)
! 	  (progn
! 	    (delete key command-line-args)
! 	    (desktop-save-mode 0))
          (when desktop-save-mode (desktop-read))))))
  
  (provide 'desktop)

Re: desktop.el not playing nice

[Stephan Stahl]

Richard Stallman said:

> Does this patch give results you like?
>
> *** desktop.el	05 Apr 2005 15:08:34 -0400	1.82
> --- desktop.el	18 Apr 2005 01:22:51 -0400
> ***************
> *** 1031,1037 ****
>     '(lambda ()
>       (let ((key "--no-desktop"))
>         (if (member key command-line-args)
> !         (delete key command-line-args)
>           (when desktop-save-mode (desktop-read))))))
>
>   (provide 'desktop)
> --- 1031,1039 ----
>     '(lambda ()
>       (let ((key "--no-desktop"))
>         (if (member key command-line-args)
> ! 	  (progn
> ! 	    (delete key command-line-args)
> ! 	    (desktop-save-mode 0))
>           (when desktop-save-mode (desktop-read))))))
>
>   (provide 'desktop)

Yes it does.

However as others have pointed out, (desktop-read) at a later time
should reenable desktop-save-mode which it does not right now.

This patch would do it.  If it's clean enough someone should commit
it too.

*** desktop.el	Mon Apr 18 20:04:26 2005	1.82
--- desktop.el	Mon Apr 18 20:13:15 2005
***************
*** 763,769 ****
                       (format ", %d to restore lazily"
                               (length desktop-buffer-args-list))
                     ""))
!         t)
        ;; No desktop file found.
        (desktop-clear)
        (let ((default-directory desktop-dirname))
--- 763,769 ----
                       (format ", %d to restore lazily"
                               (length desktop-buffer-args-list))
                     ""))
!         (desktop-save-mode 1))
        ;; No desktop file found.
        (desktop-clear)
        (let ((default-directory desktop-dirname))
-- 
Stephan Stahl

Re: desktop.el not playing nice

[Lars Hansen]

Stephan Stahl wrote:
> However as others have pointed out, (desktop-read) at a later time
> should reenable desktop-save-mode which it does not right now.

I disagree. The command desktop-read is supposed to reload a saved 
desktop and nothing else, it should never change desktop-save-mode. We 
have the command desktop-save-mode to do that. I believe it would be 
confusing if desktop-read behaved differently when emacs is started with 
--no-desktop.

Re: desktop.el not playing nice

[Lars Hansen]

Stephan Stahl wrote:

>   Specify the option `--no-desktop' on the command line when you don't
>want it to reload any saved desktop.
>  
>
IMHO this describes clearly what the --no-desktop flag does. But you may 
be right the the flag should do something different.

I can make --no-desktop disabel desktop-save-mode as you propose.
If some people don't like the flag to change desktop-save-mode, I could 
add a second flag --no-desktop-load that only inhibits desktop loading.

What do people like best:
1. Just change --no-desktop to disabel desktop-save-mode.
2. Change --no-desktop to disabel desktop-save-mode and introduce a 
second flag --no-desktop-load.
3. Something else.

Re: desktop.el not playing nice

[David Kastrup]

Lars Hansen <larsh@math.ku.dk> writes:

> Stephan Stahl wrote:
>
>>   Specify the option `--no-desktop' on the command line when you don't
>>want it to reload any saved desktop.
>>  
>>
> IMHO this describes clearly what the --no-desktop flag does. But you
> may be right the the flag should do something different.
>
> I can make --no-desktop disabel desktop-save-mode as you propose.
> If some people don't like the flag to change desktop-save-mode, I
> could add a second flag --no-desktop-load that only inhibits desktop
> loading.
>
> What do people like best:
> 1. Just change --no-desktop to disabel desktop-save-mode.

That.  Other effects are too confusing to warrant a separate option:
you can achieve them by setting variables manually.

However, when calling desktop-read explicitly in a --no-desktop
session, desktop-save-mode should probably be reset to the customized
default.  At least I think that is more or less what people would
expect.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: desktop.el not playing nice

[Lennart Borgman]

----- Original Message ----- 
From: "David Kastrup" <dak@gnu.org>

> > What do people like best:
> > 1. Just change --no-desktop to disabel desktop-save-mode.
> 
> That.  Other effects are too confusing to warrant a separate option:
> you can achieve them by setting variables manually.
> 
> However, when calling desktop-read explicitly in a --no-desktop
> session, desktop-save-mode should probably be reset to the customized
> default.  At least I think that is more or less what people would
> expect.

I would expect a question about resetting.

Re: desktop.el not playing nice

[Lars Hansen]

David Kastrup wrote:

>However, when calling desktop-read explicitly in a --no-desktop
>session, desktop-save-mode should probably be reset to the customized
>default.  At least I think that is more or less what people would
>expect.
>  
>
I think it would be confusing if desktop-read behaved differently in a 
session started with --no-desktop that in other sessions. If one wants 
desktop saving turned on again, one should use the command 
desktop-save-mode.

Re: desktop.el not playing nice

[Richard Stallman]

    1. Just change --no-desktop to disabel desktop-save-mode.

I think that is the right change.  How about this?

*** desktop.el	05 Apr 2005 15:08:34 -0400	1.82
--- desktop.el	18 Apr 2005 01:22:51 -0400	
***************
*** 1031,1037 ****
    '(lambda ()
      (let ((key "--no-desktop"))
        (if (member key command-line-args)
!         (delete key command-line-args)
          (when desktop-save-mode (desktop-read))))))
  
  (provide 'desktop)
--- 1031,1039 ----
    '(lambda ()
      (let ((key "--no-desktop"))
        (if (member key command-line-args)
! 	  (progn
! 	    (delete key command-line-args)
! 	    (desktop-save-mode 0))
          (when desktop-save-mode (desktop-read))))))
  
  (provide 'desktop)

Re: desktop.el not playing nice

[Stephan Stahl]

Hi Richard.

Richard Stallman said:

>     1. Just change --no-desktop to disabel desktop-save-mode.
>
> I think that is the right change.  How about this?

Lars Hansen commited a patch that does just this sligthly
diffrent..
-- 
Stephan Stahl

Re: desktop.el not playing nice

[Lars Hansen]

Stephan Stahl wrote:

>Maybe --no-desktop should disable desktop-save-mode?
>  
>
I just installed a change to make --no-desktop switch off desktop-save mode.

BTW, I now see that RMS have proposed essentially the same patch.