bug#6091: 23.1.96; fringe face can not be remapped

bug#6091: 23.1.96; fringe face can not be remapped

[Leo]

It seems fringe is about the only face that can't be remapped. For
example, eval:

  (push '(fringe (:foreground "#71d3b4" :background
                  "#233323"))
        face-remapping-alist)

and you will see no change on the fringes.

Leo

bug#6091: 23.1.96; fringe face can not be remapped

[Chong Yidong]

> It seems fringe is about the only face that can't be remapped.

Should be fixed now in the trunk, thanks.

bug#6091: 23.1.96; fringe face can not be remapped

[Leo]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

On 2010-07-06 21:25 +0100, Chong Yidong wrote:
>> It seems fringe is about the only face that can't be remapped.
>
> Should be fixed now in the trunk, thanks.

The fix only worked partially. See the attached screenshot:


[-- Attachment #2: Screen shot 2010-07-07 at 00.56.34.png --]
[-- Type: image/png, Size: 63453 bytes --]

[-- Attachment #3: Type: text/plain, Size: 205 bytes --]


part of the fringes still use the old face.

BTW, the 'cursor' face seems to have a similar issue, i.e.

    (push '(cursor (:background "red")) face-remapping-alist)

does not do anything.

Thanks.

Leo

bug#6091: 23.1.96; fringe face can not be remapped

[Leo]

reopen 6091

I have re-opened this bug for now.

bug#6091: 23.1.96; fringe face can not be remapped

[Chong Yidong]

Leo <sdl.web@gmail.com> writes:

> On 2010-07-06 21:25 +0100, Chong Yidong wrote:
>>> It seems fringe is about the only face that can't be remapped.
>>
>> Should be fixed now in the trunk, thanks.
>
> The fix only worked partially. See the attached screenshot:

I can't reproduce this.  Please provide a recipe.

bug#6091: 23.1.96; fringe face can not be remapped

[Leo]

On 2010-07-10 19:01 +0100, Chong Yidong wrote:
>> The fix only worked partially. See the attached screenshot:
>
> I can't reproduce this.  Please provide a recipe.

1. emacs -Q
2. paste the following into *scratch*

  (push '(fringe (:foreground "#71d3b4" :background
                  "#233323"))
        face-remapping-alist)

3. C-j (not C-x C-e)

Leo

bug#6091: 23.1.96; fringe face can not be remapped

[Chong Yidong]

Leo <sdl.web@gmail.com> writes:

> 1. emacs -Q
> 2. paste the following into *scratch*
>
>   (push '(fringe (:foreground "#71d3b4" :background
>                   "#233323"))
>         face-remapping-alist)
>
> 3. C-j (not C-x C-e)

This is because the Emacs redisplay engine doesn't repaint the parts of
the screen unless it has changed, and it has no way to know that you've
changed the variable `face-remapping-alist'.  You can order a refresh by
calling `redraw-display'.

We could set up a more elaborate system for the redisplay engine to keep
track of `face-remapping-alist', but I don't think it's warranted, and
it may slow down the much more common case where `face-remapping-alist'
never changes.  Instead, I will update the doc of `face-remapping-alist'
to mention this issue.