From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.bugs Subject: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files Date: Wed, 27 Mar 2013 23:36:53 +0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1364399069 1507 80.91.229.3 (27 Mar 2013 15:44:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Mar 2013 15:44:29 +0000 (UTC) To: 14066@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 27 16:44:56 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKsWt-0001nV-5R for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Mar 2013 16:44:47 +0100 Original-Received: from localhost ([::1]:37400 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsWV-0004xY-7e for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Mar 2013 11:44:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsWR-0004xT-0K for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:44:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsSs-0005Lj-Kv for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:41:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsSs-0005Lf-GP for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:40:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UKsVD-0001M7-BL for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:43:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2013 15:43:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13643989755173 (code B ref -1); Wed, 27 Mar 2013 15:43:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Mar 2013 15:42:55 +0000 Original-Received: from localhost ([127.0.0.1]:47732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsV0-0001LK-MA for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:42:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41354) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsUu-0001Kx-Oo for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:42:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsSU-00055W-3d for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:40:19 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:44877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsSU-000545-10 for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:40:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsPO-0001Dy-He for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsPN-0003Vg-8P for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:02 -0400 Original-Received: from mail-pd0-f171.google.com ([209.85.192.171]:42294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsPN-0003VZ-2B for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:01 -0400 Original-Received: by mail-pd0-f171.google.com with SMTP id z10so1585083pdj.16 for ; Wed, 27 Mar 2013 08:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=pIKcrqgTei2IWet6dyn/WNfIHPDgTElRrFFUcVJplR4=; b=DBmkwHZx36YDTG/hyp1RQa5J+dvbGrIrpfWQSY2c1BC+xJ8yJsXnTkAqDLyZBiFPM9 +LqPxmKEatJAE/p46imT+Cxl6rEJMIUTcO3CPYxscyXQy1hWAIiUlbulc4EaB16gj2cE CygMF3ZLAgfJnaou8d+tLlrsl02S3Z4CnWqjPQBBwBugn17zd8Kx9TJttK32tjZ7GzFt Hg3D0V5B4r+h/kHg/BCdrxg35tDd3cv0es/WkxZTCZysvNTKGiyavXBBPrrt7wsCtsDp RIQei5WV6wR9BRPd3uD+pjE6j9+TP03gg5NUzr5k+YZeiHaasll6JGIh/Sxda/o3z9/E 9p6g== X-Received: by 10.68.180.193 with SMTP id dq1mr30292783pbc.67.1364398620199; Wed, 27 Mar 2013 08:37:00 -0700 (PDT) Original-Received: from Zeuss-MacBook.local ([111.161.47.175]) by mx.google.com with ESMTPS id i10sm21902138pbd.1.2013.03.27.08.36.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 Mar 2013 08:36:59 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72941 Archived-At: According to vc-default-make-version-backups-p, no backup file is created for the bzr backend. However 'bzr revert' itself creates backups which is very confusing. So I propose the following patch: diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el index f436d300..c1195eee 100644 --- a/lisp/vc/vc-bzr.el +++ b/lisp/vc/vc-bzr.el @@ -644,7 +644,7 @@ (defun vc-bzr-checkout (_file &optional _editable rev) (defun vc-bzr-revert (file &optional contents-done) (unless contents-done - (with-temp-buffer (vc-bzr-command "revert" t 0 file)))) + (with-temp-buffer (vc-bzr-command "revert" t 0 file "--no-backup")))) (defvar log-view-message-re) (defvar log-view-file-re)