all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Liu <sdl.web@gmail.com>
To: Julien Danjou <julien@danjou.info>
Cc: 6852@debbugs.gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: bug#6852: 24.0.50; Wrong behaviour with `ido-enter-matching-directory' set to 'first
Date: Sat, 13 Jul 2013 09:07:52 +0800	[thread overview]
Message-ID: <m18v1bl11z.fsf@gmail.com> (raw)
In-Reply-To: <87k3kwfbrj.fsf@dex.adm.naquadah.org> (Julien Danjou's message of "Fri, 12 Jul 2013 10:00:48 +0200")

On 2013-07-12 16:00 +0800, Julien Danjou wrote:
> The problem isn't that it picks vimperator, the problem is that the
> prompt shows Org/ as the first candidate in the list and that when
> pressing / I expect it to respect what it showed me. :(

I committed a fix. Will you be able to test it from emacs-trunk?

Thanks,
Leo


From ba377187a3a81358a349e806d24cc7cdf44f4b6b Mon Sep 17 00:00:00 2001
Date: Sat, 13 Jul 2013 08:57:47 +0800
Subject: [PATCH] * ido.el (ido-exhibit): Handle ido-enter-matching-directory
 before ido-set-matches call.

---
 lisp/ido.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/lisp/ido.el b/lisp/ido.el
index 9c4e5654..ce43e866 100644
--- a/lisp/ido.el
+++ b/lisp/ido.el
@@ -4482,11 +4482,6 @@ (defun ido-exhibit ()
 	  (setq ido-exit 'refresh)
 	  (exit-minibuffer))
 
-	;; Update the list of matches
-	(setq ido-text contents)
-	(ido-set-matches)
-	(ido-trace "new    " ido-matches)
-
 	(when (and ido-enter-matching-directory
 		   ido-matches
 		   (or (eq ido-enter-matching-directory 'first)
@@ -4500,6 +4495,11 @@ (defun ido-exhibit ()
 	  (setq ido-exit 'refresh)
 	  (exit-minibuffer))
 
+	;; Update the list of matches
+	(setq ido-text contents)
+	(ido-set-matches)
+	(ido-trace "new    " ido-matches)
+
 	(when (and (boundp 'ido-enable-virtual-buffers)
 		   (not (eq ido-enable-virtual-buffers 'always))
 		   (eq ido-cur-item 'buffer)
-- 
1.8.3





  reply	other threads:[~2013-07-13  1:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13 22:36 bug#6852: 24.0.50; Wrong behaviour with `ido-enter-matching-directory' set to 'first Julien Danjou
2013-07-12  7:42 ` Leo Liu
2013-07-12  8:00   ` Julien Danjou
2013-07-13  1:07     ` Leo Liu [this message]
2013-07-15  8:11       ` Leo Liu
2013-07-15  8:30       ` Julien Danjou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m18v1bl11z.fsf@gmail.com \
    --to=sdl.web@gmail.com \
    --cc=6852@debbugs.gnu.org \
    --cc=julien@danjou.info \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.