From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Daniel_Mart=C3=ADn?= Newsgroups: gmane.emacs.devel Subject: Re: Tab advance for tabulated-list-mode [CODE ATTACHED] Date: Sun, 17 Jan 2021 17:00:05 +0100 Message-ID: References: <20210117071759.ge3gqdnucoc7jrm2@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36565"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: Boruch Baum , Emacs-Devel List To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 17 17:01:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l1AUK-0009QH-V2 for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 17:01:13 +0100 Original-Received: from localhost ([::1]:57010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1AUJ-00007X-Um for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Jan 2021 11:01:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1ATT-0007vN-MH for emacs-devel@gnu.org; Sun, 17 Jan 2021 11:00:19 -0500 Original-Received: from sonic304-22.consmr.mail.ir2.yahoo.com ([77.238.179.147]:46520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1ATQ-0000KM-LA for emacs-devel@gnu.org; Sun, 17 Jan 2021 11:00:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1610899213; bh=WeI98FNMw6KyzTGCReJiO/BRGZR276U2V8Ibe7/pAgU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=LIS/TzKHNuZXgM5XgflWYZKBI0gt+iq7GjUdnSTobvy8sQG+8KGSTK4PlbPuVFDi4KL0aqDypu6VwQzKB3gKLBneeEQ6OVm+YcclaKSP4myqtR364AXy9DXmzalEeUgTXcUxDdxj2tpTl8bSwIFa8fgQvHyLxT4qntltkoFSioWOaiitMa1GGz8kuoQZTy6DKmZfx9MaOkKlotwrbNROAOe/psXMZVrGiJSaU0H3w9jwM0yOlOqndpb8gjOadDIFcX+tgOvm5zj3RvqJLjKQTOCFQIwY+pqCRuanrag9gQUei2Bn20QjnB4uxMmB/WDQ2nGYnDHEEefAQ+4DEZsAXw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1610899213; bh=PcRpZsHGYMBGBSScdyyhVv1podNkYgG4CNAq8hLQWjp=; h=From:To:Subject:Date:From:Subject:Reply-To; b=bN9WbT8qkVqP+gh9RrmItiOr4fPI9OEGMVKSQt7pLGK/B9ongni+OqCgMlg0GeTeBqulnAJbPmYdktwsC7gUpApHKzJe2kLcv1oHRQnCncEjF5u8MHkBRXxkzQbFnsxGGiftD4cBxPA8Oxuz9NT8TUO8T5Pqiyf09yMbhnkZ4JsFrhFAi9ujh0b/sntQm9Ueez3xKf/x+u2qeO+wjTpRU3+HkzQ5CTlVY6s63lDa4VxwDkzfrZO2G80u1zbinW8DDRVtlUiggpsVejg3TLY2zDtiG9kuFo6AOluz7xxOGt+tUolS2Cf1XccAafw9nvQ/8kgX3B/DbcULJCxqsL3JSA== X-YMail-OSG: GS7fB4EVM1m9Xi81r1x0G9sIA0Wv9qHFlX7901Mq2CWXo62oPHT3t18vOO2XETC d.tNSqlGDirK8lFErTJfYkACj5f4ZGVXMOxQs3edf1C7iFpMxnWTpk9HvPNe7NRtcau3oNDKelVO ydJioWqL2ulH5MOlj2OBkQSAH41iDHNaViVolLr0lWSaP_h0oZekkF0tqMHj0bk3AISYtc.J0.vc _CoyOyBQQd.QhRIjiFFLeROnnfLqpxP3xcX14XtRZ.pJtKg3rfxl3j0V0B6si969SzUvA.gOD1yA IW7AZKFTgV1EGlaMpymX7DbDBUtmaO2p7NKkTBoHcMSVhDKQF599e91gCBiLbALaWGY.0fdSJJMz LWvoiLiSUqINLSo9B9X6oLFrQRvGJATStojG7UvDac2yvfMVC4.v9caNvF1qQ93mQAutF64AAA3u v411N9epZOjIdSZ0_DUkKPKjpbVOfgZ426qCY9kDWAflUgbIzbsotSiRV8GCM5BjxprXCXbTduNk 3iF2trP1J_ljl6vgYLqY7fZFhD9Z0BQfDODuQ0cXFaIzck8K_TfasTO3bXHFjkBwTZAcxp3Ng2qv ST0n3y.Ewwe8fbQb01s.2uURPKvrRY1T0iqe_rgIFtUbJHKwMrq9JemSu6C.c_Lmwt9Ya8IL5kVN V_SsTTLcHIaNY_D7PoVeQScgrY86bDV2XF8OcJi3id4cl360rQzzYncxP_mvxyEbmJ4gSjW9zBbu WfsuoG_4VbwMPBXI52dhqE12DLtPHleWQE1PFEm8aBNR0tRaOh8H3XAdpsUhvitsWwFdOj_EiQpU oyjRTtfUcqhExbtCzo9bs567Q23moh8noLP_UnS.yd Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ir2.yahoo.com with HTTP; Sun, 17 Jan 2021 16:00:13 +0000 Original-Received: by smtp420.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID db02a6bd2d933118739b60c504ea2ee0; Sun, 17 Jan 2021 16:00:09 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Sun, 17 Jan 2021 10:20:26 -0500") X-Mailer: WebService/1.1.17501 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=77.238.179.147; envelope-from=mardani29@yahoo.es; helo=sonic304-22.consmr.mail.ir2.yahoo.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263131 Archived-At: Stefan Monnier writes: >>> >>> (define-key tabulated-list-mode-map "\t" 'tabulated-list-tab-forward) >>> (define-key tabulated-list-mode-map (kbd "") 'tabulated-list-tab-backward) >> >> >> How would this work when the tabulated list has one or more buttons? > > Presumably the major mode will be derived from `tabulated-list-mode` and > the keymap will have `tabulated-list-mode-map` as its parent, so any > specific local bindings (or local buttons) should take precedence, so > the above patch shouldn't cause a regression. I didn't mean a regression, but a change in behavior. I've installed the patch locally, and pressing TAB in *Packages* now goes from column to column. Before the patch, it went from package to package. We can either: a) Accept the new behavior, as it is more intuitive in my opinion. b) Override the binding in package.el, to preserve the original behavior. (The same may happen to other packages that inherit from tabulated-list-mode.) I'm in favor of the change. If it's documented well in NEWS, it shouldn't cause much trouble if packages need to adapt to it.