From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Date: Fri, 03 Sep 2021 11:08:02 +0200 Message-ID: References: <87pmtqummr.fsf@runbox.com> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10433"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50345@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 03 11:24:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mM5Qs-0002UA-Ua for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 11:24:24 +0200 Original-Received: from localhost ([::1]:37382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM5Qr-0004mI-M2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 03 Sep 2021 05:24:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM5C2-0005q9-Gm for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 05:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mM5C2-0001NI-7P for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 05:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mM5C2-0005H8-2d for bug-gnu-emacs@gnu.org; Fri, 03 Sep 2021 05:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Sep 2021 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50345-submit@debbugs.gnu.org id=B50345.163066009020203 (code B ref 50345); Fri, 03 Sep 2021 09:09:02 +0000 Original-Received: (at 50345) by debbugs.gnu.org; 3 Sep 2021 09:08:10 +0000 Original-Received: from localhost ([127.0.0.1]:42936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM5BC-0005Fn-9k for submit@debbugs.gnu.org; Fri, 03 Sep 2021 05:08:10 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]:54176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mM5B9-0005Fa-N7 for 50345@debbugs.gnu.org; Fri, 03 Sep 2021 05:08:09 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1630660084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YJRb/BP6G6v6xSBPE+jMQq/FQX+zi2mh3Mttlg1qVuw=; b=g/5KDoGWAI2JXPgP6/Yy7pgcxXdFp0jNnCJRP1TsK98txNtFOPJkdOEMCSd+1F85Lajppj YEYw9u6gVkg3vBxjB9KNMCplm/ffYwViPH/cmHr7SJRqDbCPJsgl/LLzh9hdoGEBxeHNM6 cCmp1JnBSB/FQ4iYBZA/5pVA31GgM0toF48xI5gq4McrSSVSbi/D5mzWCjlGGPyVWYhIzZ tbaeYdUvmO6BdoHXgbofQd6otnTSBx2ga/AlUhd5btisavskgAN1w3Ahip9IVPiU8spQ5K Tr22Pg36FoOgRbhL1LjDNr5VExYGWxBDHjoCWwrcoFDNvOWJmahvLz4QJYdF3w== In-Reply-To: <87pmtqummr.fsf@runbox.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213344 Archived-At: Hi, Simen! > > Thanks! My pleasure! > >> I see that some properties are extracted out into variables, but not >> sure what is standard practice here. > > I've previously tried keeping them one-to-one with the property index > grammars (https://www.w3.org/TR/css-align-3/#property-index). > > So for instance `place-content` would just refer back to `align-content` > and `justify-content` without the need to repeat their properties: > > ("place-content" align-content justify-content) > > `align-content` is a bit more convoluted, with a mix of a literal value > and value classes in the grammar: > > ("align-content" "normal" baseline-position content-distribution > overflow-position content-position) > > The value classes aren't properties, so their values go into > `css-value-class-alist`. For instance, `baseline-position` can take > values: > > (baseline-position "first" "last" "baseline") > > This can then be reused by other properties again. > > Does this make sense? I should probably document this practice a bit > better. =F0=9F=98=85 > Yeah, this is the answer I wanted. I'll look into doing this in the next patches I send. I think it would be nice to document this down the line as well, yes. I can see what I can do about that too :) Have a nice weekend! Theodor