From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Simen Heggestøyl" <simenheg@runbox.com>
Cc: 50345@debbugs.gnu.org
Subject: bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el
Date: Fri, 03 Sep 2021 11:08:02 +0200 [thread overview]
Message-ID: <m18s0ejabx.fsf@Frende-MacBook.lan> (raw)
In-Reply-To: <87pmtqummr.fsf@runbox.com>
Hi, Simen!
>
> Thanks!
My pleasure!
>
>> I see that some properties are extracted out into variables, but not
>> sure what is standard practice here.
>
> I've previously tried keeping them one-to-one with the property index
> grammars (https://www.w3.org/TR/css-align-3/#property-index).
>
> So for instance `place-content` would just refer back to `align-content`
> and `justify-content` without the need to repeat their properties:
>
> ("place-content" align-content justify-content)
>
> `align-content` is a bit more convoluted, with a mix of a literal value
> and value classes in the grammar:
>
> ("align-content" "normal" baseline-position content-distribution
> overflow-position content-position)
>
> The value classes aren't properties, so their values go into
> `css-value-class-alist`. For instance, `baseline-position` can take
> values:
>
> (baseline-position "first" "last" "baseline")
>
> This can then be reused by other properties again.
>
> Does this make sense? I should probably document this practice a bit
> better. 😅
>
Yeah, this is the answer I wanted. I'll look into doing this in the next
patches I send. I think it would be nice to document this down the line
as well, yes. I can see what I can do about that too :)
Have a nice weekend!
Theodor
next prev parent reply other threads:[~2021-09-03 9:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 18:46 bug#50345: 28.0.50; [PATCH] Filling holes in css-mode.el Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-02 21:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-03 7:46 ` Simen Heggestøyl
2021-09-03 9:08 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-09-03 6:15 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18s0ejabx.fsf@Frende-MacBook.lan \
--to=bug-gnu-emacs@gnu.org \
--cc=50345@debbugs.gnu.org \
--cc=simenheg@runbox.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.