Re: ELPA: New package: svg-lib

["Nicolas P. Rougier (inria)" <nicolas.rougier@inria.fr>]

Thanks for the report. I've fixed most of them and let you know 
when everythign is fixed.

May I ask how you get such detailed report on the byte 
compilation? Mine output is much smaller and do not report 
everything (I simply used the byte-compile-file).

Nicolas

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Nicolas P. Rougier (inria) [2021-09-27 15:49:16] wrote:
>> generating various SVG tags, progress bars, progress pies & 
>> icons that fits
>> nicely in a text buffer.
>>
>> The library is hosted at https://github.com/rougier/svg-lib and 
>> the README
>> displays what it looks like.
>
> Looks good to me.  Before I add it, tho:
>
> - Please make sure (from now on) that contributors have signed 
> paperwork
>   (or that the sum of their contributions stays within the 
>   "trivial"
>   limit) before you accept their patches.
>
> - The svg-lib-demo.el lacks a `;; Copyright (C) 2021 Free 
> Software Foundation, Inc.`
>
> Also, see below the warnings I got when trying to byte-compile 
> it.
> And while I'm here I'd recommend allowing the users to *load* 
> svg-lib.el
> even if (not (image-type-available-p 'svg)) and only signal an 
> error
> when they actually use the library.
>
>
>         Stefan
>
>
> % make packages/svg-lib
> emacs --batch -Q -l admin/elpa-admin.el \
>          -f elpaa-batch-pkg-spec-make-dependencies .pkg-descs.mk
> Generating description file packages/svg-lib/svg-lib-pkg.el
> emacs --batch -l admin/elpa-admin.el 
> \
>          -f elpaa-batch-generate-autoloads 
>          packages/svg-lib/svg-lib-autoloads.el
>   INFO     Scraping files for svg-lib-autoloads.el... 
>   INFO     Scraping files for svg-lib-autoloads.el...done
> Byte compiling packages/svg-lib/svg-lib-demo.el
> Unable to activate package ‘tuareg’.
> Required package ‘caml-3.12.0.1’ is unavailable
> Unable to activate package ‘use-package’.
> Required package ‘bind-key-2.4’ is unavailable
> Unable to activate package ‘modus-vivendi-theme’.
> Required package ‘modus-themes-1.2.4’ is unavailable
> Unable to activate package ‘modus-operandi-theme’.
> Required package ‘modus-themes-1.2.4’ is unavailable
>
> In toplevel form:
> packages/svg-lib/svg-lib-demo.el:41:3:Warning: reference to free 
> variable
>     ‘GNU’
> packages/svg-lib/svg-lib-demo.el:41:7:Warning: reference to free 
> variable
>     ‘Emacs’
> Byte compiling packages/svg-lib/svg-lib.el
> Unable to activate package ‘tuareg’.
> Required package ‘caml-3.12.0.1’ is unavailable
> Unable to activate package ‘use-package’.
> Required package ‘bind-key-2.4’ is unavailable
> Unable to activate package ‘modus-vivendi-theme’.
> Required package ‘modus-themes-1.2.4’ is unavailable
> Unable to activate package ‘modus-operandi-theme’.
> Required package ‘modus-themes-1.2.4’ is unavailable
>
> In toplevel form:
> packages/svg-lib/svg-lib.el:91:1:Warning: defcustom for
>     ‘svg-lib-icon-collections’ provides redundant :group
> packages/svg-lib/svg-lib.el:115:1:Warning: defcustom for 
> ‘svg-lib-icons-dir’
>     provides redundant :group
> packages/svg-lib/svg-lib.el:152:1:Warning: defcustom for
>     ‘svg-lib-style-default’ provides redundant :group
>
> In svg-lib-style:
> packages/svg-lib/svg-lib.el:177:44:Warning: Unused lexical 
> variable `value'
>
> In svg-lib-tag:
> packages/svg-lib/svg-lib.el:214:40:Warning: Unused lexical 
> variable `width'
> packages/svg-lib/svg-lib.el:217:40:Warning: Unused lexical 
> variable `scale'
> packages/svg-lib/svg-lib.el:229:33:Warning: Unused lexical 
> variable
>     `tag-char-height'
>
> In svg-lib-progress-pie:
> packages/svg-lib/svg-lib.el:267:40:Warning: Unused lexical 
> variable `width'
> packages/svg-lib/svg-lib.el:269:40:Warning: Unused lexical 
> variable `scale'
> packages/svg-lib/svg-lib.el:274:40:Warning: Unused lexical 
> variable
>     `font-weight'
> packages/svg-lib/svg-lib.el:280:66:Warning: Unused lexical 
> variable `ascent'
> packages/svg-lib/svg-lib.el:281:33:Warning: Unused lexical 
> variable
>     `tag-char-width'
> packages/svg-lib/svg-lib.el:282:33:Warning: Unused lexical 
> variable
>     `tag-char-height'
> packages/svg-lib/svg-lib.el:289:27:Warning: Unused lexical 
> variable `tag-x'
> packages/svg-lib/svg-lib.el:299:33:Warning: reference to free 
> variable ‘pi’
>
> In svg-lib-progress-bar:
> packages/svg-lib/svg-lib.el:340:40:Warning: Unused lexical 
> variable `scale'
> packages/svg-lib/svg-lib.el:345:40:Warning: Unused lexical 
> variable
>     `font-weight'
> packages/svg-lib/svg-lib.el:351:66:Warning: Unused lexical 
> variable `ascent'
> packages/svg-lib/svg-lib.el:352:33:Warning: Unused lexical 
> variable
>     `tag-char-width'
> packages/svg-lib/svg-lib.el:353:33:Warning: Unused lexical 
> variable
>     `tag-char-height'
>
> In svg-lib-icon:
> packages/svg-lib/svg-lib.el:427:40:Warning: Unused lexical 
> variable
>     `font-size'
> packages/svg-lib/svg-lib.el:428:40:Warning: Unused lexical 
> variable
>     `font-family'
> packages/svg-lib/svg-lib.el:429:40:Warning: Unused lexical 
> variable
>     `font-weight'
> packages/svg-lib/svg-lib.el:444:20:Warning: string-to-number 
> quoted with '
>     rather than with #'
> packages/svg-lib/svg-lib.el:471:35:Warning: Unused lexical 
> variable `fill'
>
> In svg-lib-button:
> packages/svg-lib/svg-lib.el:508:28:Warning: Unused lexical 
> variable
>     `box-width'
> packages/svg-lib/svg-lib.el:509:36:Warning: Unused lexical 
> variable
>     `box-height'
> packages/svg-lib/svg-lib.el:515:33:Warning: Unused lexical 
> variable
>     `tag-char-height'
> packages/svg-lib/svg-lib.el:557:35:Warning: Unused lexical 
> variable `fill'
>
> In end of data:
> packages/svg-lib/svg-lib.el:167:18:Warning: the function 
> ‘color-rgb-to-hex’ is
>     not known to be defined.