From: "Nicolas P. Rougier (inria)" <nicolas.rougier@inria.fr>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: ELPA: New package: nano-theme
Date: Tue, 28 Sep 2021 19:57:16 +0200 [thread overview]
Message-ID: <m18rzgwoxw.fsf@inria.fr> (raw)
In-Reply-To: <87bl4c6197.fsf@posteo.net>
Many thanks for the review and the feedback.
Philip Kaludercic <philipk@posteo.net> writes:
> "Nicolas P. Rougier (inria)" <nicolas.rougier@inria.fr> writes:
> I see that a lot of faces inherit from nano-default,
> nano-strong,
> nano-faded, etc. Wouldn't it make more sense to inherit from
> built-in
> faces and then let default, bold, shadow, etc. inherit from
> these faces.
Having such names helps a lot when you assign faces. For example,
when I define font-lock-comment-face, I want to make it faded and
it feels more natural and explicit to inherit from
nano-faded. Also, is there an associated computational cost when
defining a new face?
> Furthermore, I wonder why you define the commands nano-light and
> nano-dark, instead of two themes, nano-light and nano-dark
> (along the
> same lines of what modus-themes currently does). You could also
> turn
> nano-setup into a custom theme, so that the user can easily
> enable and
> disable it.
Maybe I need to read the documentation on what a theme can
set. For example, I set the face for the minibuffer (0 & 1) and
echo area (0 & 1) and I wasn't sure how to specify this in a
theme. Same for underline to be set at descent line, etc.
> A few more points:
>
> - Should the font really be part of the face? I think it makes
> sense to
> recommend a few fonts, but it is unconventional to add it as
> part of a
> theme.
I agree this might be unconventional but since you can specify a
font family for each face, why not use it? And user can still
choose its own font stack.
> - When you are only using one branch of a if expression, prefer
> when. Instead of (if (not ...) ...), prefer unless.
Thanks, I'll do that.
> - Lines 363ff. seem to be indented unconventionally. Maybe add a
> .dir-locals.el to make sure everyone is using the same
> whitespace
> configuration.
Not sure what you mean by add a .dir-locals.el.
Can you give me a pointer to the documentation?
> Also, as you depend on at least 27.1, you probably don't have to
> check
> if custom-theme-load-path is defined. The same applies to
> tooltip-mode,
> scroll-bar-mode and tool-bar-mode. What you are doing looks more
> like
> configuration code, where you want to make sure that a .emacs
> works on
> older versions of Emacs.
Thansk, didn't know, I'll correct it.
Nicolas
next prev parent reply other threads:[~2021-09-28 17:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 13:11 ELPA: New package: nano-theme Nicolas P. Rougier (inria)
2021-09-28 17:47 ` Philip Kaludercic
2021-09-28 17:57 ` Nicolas P. Rougier (inria) [this message]
2021-09-28 18:32 ` Stefan Kangas
2021-09-28 18:48 ` Stefan Monnier
2021-09-29 15:20 ` Stefan Kangas
2021-09-29 16:39 ` Stefan Monnier
2021-09-29 5:13 ` Nicolas P. Rougier (inria)
2021-09-29 12:18 ` Stefan Monnier
2021-09-30 7:21 ` Nicolas P. Rougier (inria)
2021-09-28 18:37 ` Philip Kaludercic
2021-09-29 5:07 ` Nicolas P. Rougier (inria)
2021-09-29 6:24 ` Philip Kaludercic
2021-10-01 9:59 ` Philip Kaludercic
2021-10-01 10:05 ` Nicolas P. Rougier (inria)
2021-10-01 10:15 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18rzgwoxw.fsf@inria.fr \
--to=nicolas.rougier@inria.fr \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.