From: "Daniel Martín" <mardani29@yahoo.es>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: "Daniel Colascione" <dancol@dancol.org>,
"Dmitry Gutov" <dgutov@yandex.ru>, "Alan Mackenzie" <acm@muc.de>,
"João Távora" <joaotavora@gmail.com>,
"Yuan Fu" <casouri@gmail.com>, "Eli Zaretskii" <eliz@gnu.org>,
"theodor thornhill" <theo@thornhill.no>,
geza.herman@gmail.com, emacs-devel@gnu.org
Subject: Re: treesit indentation "blinking"
Date: Sat, 08 Apr 2023 20:59:03 +0200 [thread overview]
Message-ID: <m18rf242vc.fsf@yahoo.es> (raw)
In-Reply-To: <f83e2df3-8eca-7eb1-6ecc-b40f21537d3f@gutov.dev> (Dmitry Gutov's message of "Sat, 8 Apr 2023 04:32:13 +0300")
Dmitry Gutov <dmitry@gutov.dev> writes:
> On 07/04/2023 17:20, Daniel Martín wrote:
>> In general, I'd suggest taking a look at Neovim's Tree-sitter
>> implementation and perhaps reuse (part of) their .scm Tree-sitter syntax
>> highlight or indentation queries:
>> https://github.com/nvim-treesitter/nvim-treesitter/tree/master/queries/c
>> Neovim's implementation doesn't "blink" in the scenarios presented here,
>> but I'm not sure about how it performs in other tricky cases.
>
> Looking at that file, it does contain queries that look for ERROR
> nodes, e.g.
>
> (
> ERROR
> "for" "(" @indent.begin ";" ";" ")" @indent.end)
>
> So perhaps we should revisit that approach too.
>
>> Now that text editors have access to the same programming language
>> grammars, I'm surprised the Tree-sitter community hasn't started any
>> cross-team effort to work on canonical queries (or slighter richer
>> abstractions) per programming language. Text editor developers are
>> working and rediscovering complex language problems independently.
>
> We could do an indent implementation that just uses these indents.scm
> files. Not exactly sure why we didn't start out this way, but note
> that our Lisp based solution is a lot more flexible.
>
> E.g. there doesn't seem to be an obvious way to support "indentation
> styles" with these.
I think it may be possible to have different query files, say,
"GNU.scm", "K&R.scm", "C.scm" and add to the beginning of "GNU.scm" a
Lisp comment like "; import C.scm". We would need to do manual parsing
of the .scm files, though.
Another question is how flexible this mechanism is. If I change
something in an .scm file, would I need to restart Emacs to see the
results? We could turn the .scm files into proper data Emacs Lisp files
that could be evaluated on the fly, I don't know how over-engineered
that'd be. Also, I don't know if we could even satisfy advanced CC mode
users who are used to modify their style by just invoking C-c C-o on the
line whose indentation they want to change.
Even if we don't use external .scm files, perhaps we could add the
queries in them to our Tree-sitter rules? I think we'd need a new
Tree-sitter matcher to match them properly, right?
next prev parent reply other threads:[~2023-04-08 18:59 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 20:49 treesit indentation "blinking" Daniel Colascione
2023-03-23 0:00 ` Yuan Fu
2023-03-23 0:07 ` Daniel Colascione
2023-03-23 1:02 ` Yuan Fu
2023-03-23 4:51 ` Daniel Colascione
2023-03-23 20:04 ` Yuan Fu
2023-03-23 21:10 ` Daniel Colascione
2023-03-23 21:24 ` Dmitry Gutov
2023-03-25 9:05 ` João Távora
2023-03-25 12:42 ` Dmitry Gutov
2023-03-25 14:42 ` Eli Zaretskii
2023-03-25 16:18 ` João Távora
2023-03-28 22:11 ` João Távora
2023-03-28 23:57 ` Daniel Colascione
2023-03-29 2:26 ` Eli Zaretskii
2023-03-29 22:30 ` João Távora
2023-03-29 22:37 ` Herman, Géza
2023-03-29 23:25 ` João Távora
2023-03-30 7:47 ` Herman, Géza
2023-03-29 22:56 ` Lynn Winebarger
2023-03-30 7:43 ` Eli Zaretskii
2023-03-30 8:58 ` Dmitry Gutov
2023-03-30 9:15 ` João Távora
2023-03-30 9:06 ` João Távora
2023-03-30 9:20 ` Dmitry Gutov
2023-03-30 9:28 ` João Távora
2023-03-30 9:36 ` Dmitry Gutov
2023-03-30 10:00 ` João Távora
2023-03-30 16:29 ` Dmitry Gutov
2023-03-30 17:14 ` João Távora
2023-03-30 10:07 ` Eli Zaretskii
2023-03-30 10:26 ` Herman, Géza
2023-03-30 13:39 ` Eli Zaretskii
2023-03-30 15:03 ` Herman, Géza
2023-03-30 14:58 ` Eli Zaretskii
2023-04-01 19:39 ` Yuan Fu
2023-04-02 1:49 ` Yuan Fu
2023-04-02 5:31 ` Eli Zaretskii
2023-04-02 14:26 ` Alan Mackenzie
2023-04-02 15:48 ` João Távora
2023-04-02 17:04 ` Alan Mackenzie
2023-04-02 17:23 ` João Távora
2023-04-02 17:51 ` Eli Zaretskii
2023-04-02 18:04 ` João Távora
2023-04-02 18:14 ` Eli Zaretskii
2023-04-02 21:38 ` João Távora
2023-04-02 21:21 ` Dmitry Gutov
2023-04-02 21:40 ` João Távora
2023-04-03 9:59 ` Alan Mackenzie
2023-04-03 10:28 ` João Távora
2023-04-03 12:07 ` Dmitry Gutov
2023-04-03 12:56 ` Alan Mackenzie
2023-04-03 20:58 ` Dmitry Gutov
2023-04-03 21:59 ` Daniel Colascione
2023-04-03 22:10 ` Dmitry Gutov
2023-04-04 8:31 ` João Távora
2023-04-07 14:20 ` Daniel Martín
2023-04-08 1:32 ` Dmitry Gutov
2023-04-08 2:42 ` Yuan Fu
2023-04-08 18:59 ` Daniel Martín [this message]
2023-04-03 21:47 ` parser error recovery algorithm vs " Stephen Leake
2023-04-04 12:01 ` John Yates
2023-04-04 13:40 ` Dmitry Gutov
2023-04-04 16:00 ` Stephen Leake
2023-04-04 13:50 ` Stephen Leake
2023-04-04 14:05 ` Dmitry Gutov
2023-03-30 11:05 ` João Távora
2023-03-30 14:00 ` Eli Zaretskii
2023-03-30 14:43 ` João Távora
2023-03-30 14:52 ` Eli Zaretskii
2023-03-30 15:42 ` João Távora
2023-03-25 16:14 ` João Távora
2023-03-24 11:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m18rf242vc.fsf@yahoo.es \
--to=mardani29@yahoo.es \
--cc=acm@muc.de \
--cc=casouri@gmail.com \
--cc=dancol@dancol.org \
--cc=dgutov@yandex.ru \
--cc=dmitry@gutov.dev \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=geza.herman@gmail.com \
--cc=joaotavora@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.