From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 09:12:10 +0200 Message-ID: References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36687"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: kickingvegas@gmail.com, 71927@debbugs.gnu.org, "Basil L. Contovounesios" , John Paul Wallington , Juri Linkov To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 10:50:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPIAg-0009Ky-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 10:50:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPIAD-0000WF-NY; Thu, 04 Jul 2024 04:50:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPIAC-0000Vn-5T for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 04:50:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPIAB-0007GL-TS for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 04:49:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPIAD-0007L8-UU for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 04:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 08:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.172008298328177 (code B ref 71927); Thu, 04 Jul 2024 08:50:01 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 08:49:43 +0000 Original-Received: from localhost ([127.0.0.1]:41465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPI9u-0007KO-MK for submit@debbugs.gnu.org; Thu, 04 Jul 2024 04:49:43 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:47174 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPI9s-0007KE-5k for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 04:49:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1720082977; bh=w22ckqw2pKkBaUhmktnwyBGG6V/JeWSJ7jqgBfTgJT8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=b6YPaHK60fy/3KKk2egwZ3ZrKx6fdDsaw5hImhjJyhCeS8Mi66ebsX5dYlVVwuTuz d/a2t1oNKXnd8kDrhkAMtad47FQd8mQ9MpUYZDBu7fweBuyZdSAvZIVPdbqRQZWJIP /ji20JmXC3aDR9yaKhAVyUHOG3sTtg52MOsOx9sUjnxfzWdd5i115nngbOAYPCVcvE f2GxrcJitG5OvpZ6S39xND0r1ccUYtM5ABcNacYvpkq9IFAXm3GA/T2UXDS68MxQVM n80SKVbbS1gktumWwNcfPIKTcS8y5vEWziQVr0APAWhMV922tP6qhuddPt3LGrqqTg EaPWb6mrKtFRw== In-Reply-To: <861q49a8vt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Jul 2024 10:55:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288361 Archived-At: Eli Zaretskii writes: >> Cc: 71927@debbugs.gnu.org >> From: Juri Linkov >> Date: Thu, 04 Jul 2024 09:58:18 +0300 >> >> > The commands ibuffer-do-isearch and ibuffer-do-isearch-regexp >> > do not prompt for an input search string. >> >> They should not prompt because Isearch is interactive. >> But the problem is that they exit Isearch immediately. >> I tried to Edebug ibuffer-do-isearch, but this is >> not possible. > > So did I, with the same results. > > I also see that this didn't work at least as far back as Emacs 25, > maybe never. > > The function ibuffer-do-isearch was added by you, and was never > changed before. I guess it somehow violates the protocol of > define-ibuffer-op or something? Admittedly, that protocol is not > described too well in the doc string. > > I have a question: ibuffer-do-isearch just calls > multi-isearch-buffers. Does multi-isearch-buffers exit immediately, > or does it exit only when the multi-isearch is done? If the former, I > guess this is why the problem happens. > >> So we need someone who knows ibuffer internals. > > I've added two people who might be able to help. FWIW, AFAICT everything is working correctly, it's just that the "Operation finished" message hides the prompt. ibuffer-do-isearch should tell define-ibuffer-op not to display that message, somehow. Best, Eshel