From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jpw@pobox.com (John Paul Wallington) Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: 23.0.60; hexl-mode-exit doesn't cancel current address eldoc messages Date: Sat, 26 Apr 2008 02:15:06 +0100 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1209173258 27397 80.91.229.12 (26 Apr 2008 01:27:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 26 Apr 2008 01:27:38 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 26 03:28:14 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JpZD1-0000Ag-D4 for ged-emacs-devel@m.gmane.org; Sat, 26 Apr 2008 03:28:11 +0200 Original-Received: from localhost ([127.0.0.1]:33209 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JpZCL-0007W6-7p for ged-emacs-devel@m.gmane.org; Fri, 25 Apr 2008 21:27:29 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JpZCF-0007V3-LH for emacs-devel@gnu.org; Fri, 25 Apr 2008 21:27:23 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JpZCC-0007SZ-Tv for emacs-devel@gnu.org; Fri, 25 Apr 2008 21:27:22 -0400 Original-Received: from [199.232.76.173] (port=39482 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JpZCC-0007SQ-Ie for emacs-devel@gnu.org; Fri, 25 Apr 2008 21:27:20 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JpZCC-0003Rl-Af for emacs-devel@gnu.org; Fri, 25 Apr 2008 21:27:20 -0400 Original-Received: from mail.gnu.org ([199.232.76.166]:47601 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JpZC4-0001a4-El for emacs-pretest-bug@gnu.org; Fri, 25 Apr 2008 21:27:12 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JpZ0W-0001sP-MO for emacs-pretest-bug@gnu.org; Fri, 25 Apr 2008 21:15:20 -0400 Original-Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19] helo=sasl.smtp.pobox.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JpZ0W-0001rv-E2 for emacs-pretest-bug@gnu.org; Fri, 25 Apr 2008 21:15:16 -0400 Original-Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 7B9A81709 for ; Fri, 25 Apr 2008 21:15:11 -0400 (EDT) Original-Received: from mini.home (host86-138-177-169.range86-138.btcentralplus.com [86.138.177.169]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id D263A1708 for ; Fri, 25 Apr 2008 21:15:10 -0400 (EDT) X-URL: http://www.shootybangbang.com/ X-Attribution: JPW X-NSA-Fodder: cybercash Hugo Chavez clandestine MILSATCOM tempest rail gun X-Face: #uahb@^mo@bA"{q'"a4y[w$n3/V:haD\; YenWcT7)kXYx3/>#[DD9ExVe}; 9FG6X`l!Dm"V peub=u!&&?}s~{TOPtGdH)KA}/qCr; d"Gr*'9_V1PE@+K'tk2/Iq@PBKtJ+]&,CP9_Fl8'*R]LCR0| 6q; Xey'`:DX+)S.]p[KP^sNe`8B\W6(Nw{o5i)y+I!h=0bU5L`Tj`~Q0!G"t(s7o7eh)J\>P>,!~/w $$jGEVa%H%8(jTv User-Agent: Microsoft Gnus Express, Build 513.230 X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95963 gmane.emacs.pretest.bugs:22144 Archived-At: Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Do: Evaluate (add-hook 'emacs-lisp-mode-hook 'turn-on-eldoc-mode) then Visit an Emacs Lisp file then M-x hexl-mode then C-c C-c (runs hexl-mode-exit) Bug: The handy-dandy eldoc-style "current address is blah" hexl-mode messages still appear. Suggested Patch: I can install the following if aren't any objections: 2008-04-26 John Paul Wallington * hexl.el (hexl-mode): Stash `eldoc-documentation-function' in `hexl-mode-old-eldoc-documentation-function'. (hexl-mode-exit): Restore it. (hexl-mode-old-eldoc-documentation-function): Declare for compiler. --- hexl.el.~1.117.~ 2008-02-26 20:16:09.000000000 +0000 +++ hexl.el 2008-03-26 21:05:13.000000000 +0000 @@ -120,6 +120,7 @@ (defvar hexl-mode-old-require-final-newline) (defvar hexl-mode-old-syntax-table) (defvar hexl-mode-old-font-lock-keywords) +(defvar hexl-mode-old-eldoc-documentation-function) (defvar hexl-ascii-overlay nil "Overlay used to highlight ASCII element corresponding to current point.") @@ -288,6 +289,10 @@ (add-hook 'change-major-mode-hook 'hexl-maybe-dehexlify-buffer nil t) ;; Set a callback function for eldoc. + (make-local-variable 'hexl-mode-old-eldoc-documentation-function) + (setq hexl-mode-old-eldoc-documentation-function + (bound-and-true-p eldoc-documentation-function)) + (set (make-local-variable 'eldoc-documentation-function) 'hexl-print-current-point-info) (eldoc-add-command-completions "hexl-") @@ -405,6 +410,10 @@ (when (boundp 'hexl-mode-old-hl-line-face) (setq hl-line-face hexl-mode-old-hl-line-face)) + (when (boundp 'hexl-mode-old-eldoc-documentation-function) + (setq eldoc-documentation-function + hexl-mode-old-eldoc-documentation-function)) + (setq require-final-newline hexl-mode-old-require-final-newline) (setq mode-name hexl-mode-old-mode-name) (setq isearch-search-fun-function hexl-mode-old-isearch-search-fun-function) If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /Users/jpw/src/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.60.1 (i386-apple-darwin9.2.2) of 2008-04-25 on mini.home configured using `configure '--with-jpeg=no' '--with-gif=no' '--with-tiff=no' '--without-x'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: eldoc-mode: t show-paren-mode: t delete-selection-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: [elided] Recent messages: [elided]