From: Leo <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 7089@debbugs.gnu.org
Subject: bug#7089: 23.2; slow ansi-color-apply
Date: Tue, 02 Nov 2010 00:23:06 +0800 [thread overview]
Message-ID: <m17hgxau8l.fsf@cam.ac.uk> (raw)
In-Reply-To: <jwvaaludvv5.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 31 Oct 2010 15:10:32 -0400")
On 2010-11-01 03:10 +0800, Stefan Monnier wrote:
>>>> The following version fixed some glitches in setting ansi-color-context.
>>>> Also I have received an email from Alex that welcomes the improvement.
>>>> Let me know if I should send a patch in.
>>> Yes, a patch would be nice. Also a ChangeLog explaining the change
>>> (which should hopefully explain why the new code is faster) would
>>> be welcome.
>
>> Attached to the end of this message. I basically rewrite
>> ansi-color-apply using re-search-forward (as in
>> ansi-color-apply-on-region) which seems to be an order more efficient
>> than string-match.
>
>> I have been using the new version in eshell and it is almost as
>> efficient as ansi-color-apply-on-region. It is very painful to use the
>> original ansi-color-apply.
>
> Any reason why your new code does something similar to
> ansi-color-apply-on-region rather than calling
> ansi-color-apply-on-region?
`ansi-color-apply-on-region' uses overlays while `ansi-color-apply' uses
text properties.
>> Do you know for sure string-match is slower (more CPU intensive) than
>> re-search-forward?
>
> They should be largely equivalent. The difference between the two
> codes might be due to replace-match and substring. I.e. the original
> ansi-color-apply should be at least as efficient as your code (if not
> more) in the case where there are no SGR escape sequences.
>
>
> Stefan
Thanks for that info.
Leo
next prev parent reply other threads:[~2010-11-01 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 9:15 bug#7089: 23.2; slow ansi-color-apply Leo
2010-09-23 10:38 ` Leo
2010-10-28 2:38 ` Stefan Monnier
2010-10-28 4:03 ` Leo
2010-10-31 19:10 ` Stefan Monnier
2010-11-01 16:23 ` Leo [this message]
2010-11-25 14:30 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17hgxau8l.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=7089@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.