From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Unknown Newsgroups: gmane.emacs.bugs Subject: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Date: Fri, 18 Sep 2020 20:34:30 +0200 Message-ID: References: <0EB1A591-9FE4-4128-96A0-C2A8E36BC8CE@duke.edu> <20200917174640.GB635@breton.holly.idiocy.org> <32895e7e-d608-48ad-8f03-397f2d03cd06_IMAP_ADDED_MISSING@ICHABOD> <20200918125424.GF635@breton.holly.idiocy.org> Reply-To: =?UTF-8?Q?Reply-to=3A_Daniel_Mart=C3=83=C2=ADn_=3Cmardani29=40yahoo=2Ees?= =?UTF-8?Q?=3E=0A?= Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29739"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) Cc: "Paul Magwene, Ph.D." , 43470@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 18 20:41:42 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJLKI-0007dI-IQ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 20:41:42 +0200 Original-Received: from localhost ([::1]:37958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJLKH-0002gT-Ew for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Sep 2020 14:41:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJLDr-0004XS-0E for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 14:35:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJLDq-0006cW-Jq for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 14:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJLDq-0003Fe-Gp for bug-gnu-emacs@gnu.org; Fri, 18 Sep 2020 14:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 18:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43470 X-GNU-PR-Package: emacs Original-Received: via spool by 43470-submit@debbugs.gnu.org id=B43470.160045408812447 (code B ref 43470); Fri, 18 Sep 2020 18:35:02 +0000 Original-Received: (at 43470) by debbugs.gnu.org; 18 Sep 2020 18:34:48 +0000 Original-Received: from localhost ([127.0.0.1]:44375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLDc-0003Eh-5r for submit@debbugs.gnu.org; Fri, 18 Sep 2020 14:34:48 -0400 Original-Received: from sonic302-21.consmr.mail.ir2.yahoo.com ([87.248.110.84]:42141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJLDZ-0003EN-2n for 43470@debbugs.gnu.org; Fri, 18 Sep 2020 14:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1600454077; bh=dzxGWK3pAyj83K1RCJApC8SFgWX9FaG5kZypiTZdVtA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject; b=e64EHbQgmtGgKGl8wBMJxONMdahw2FW+fN0hsnipZYtM+lto2cwgoX18/xfIKUGDIe05Kskp4sl+0FZ2nTd4CjbBtHegXDnOrY3ScRVswC2M9LC2V1iJzJ+Jd5ixJIqrKt1o3hyTrOnButOcwmENqz2lKmF+mk5a7xoIwlxzHZ2DLU59pIkw1DuwZuoppScSQbyoBNyokqkC5XhU1IeXBjVcSeOupOJtcw7sl4fXhDDLiqNtdNo6eP1qZG15jy2k0FOjEDqaIYUyjOdTBLgN8fcwtWkDzlrS7FzUUE9AosKRPNpaqQkwhYItfXJ3EFQAoFZIvkjlMASY0Xxj1oL0pw== X-YMail-OSG: SJruLNAVM1kXMZwGrkYP45Q09L7vn.hjAQHv57tVOZJa2vpLfNV2wYMSfvjeW1w .NA0a1CQj3Fq9HVBbfiXG.BXFYJ7_FRY1i1qJ6afHyQHd6WkUpAnryRA81mIUsPNj0Xsf2H.10aE 4Bw6p3jB.qLj85fHgPyPLhc.ISUI4TiqIlLM9pFXS_PFBqZo5dzAsU0Od2jnxvYch8ld_X4q6ncM skBEUwicucC8pHPTNNKOr.TS0kFzbjcUHc.sIjJBFF5rrufqNClIb9YPtRdUNRnvBXVfMxHgYNAv 4iQyk7v_Ly4FCkDk5VXXOxQb0s86lQEKUeTSuFPlJ05XNs2h5OekwXBpzqtq7uFocXn02mZHhO9Y wIIDhqDooBw09UuoAX4gb6fMTPcuEKVVDA.P25d15MV.rp8msW5xOXFH8sl7jM.yTin8DaJikLtD DlCvqATtgnJGHDVm5Pg2fEi05Pbc.YSJ0sSkM0gKH2qYjOkQ8vZVXCJbaqFmzhOaquwhSVQZYWh7 QM5i.20MKKkv.XP5mC_CerR9ogppKK1d_D0O3Yg_a7H4W0U4QaH62QjWB.Gx3b6tF.E4XiR4Vlaj CCBpAKuYOy8uFvE9xBYnXFeMAm7NPl4chj_Mc10sSQ2sy6mFRTlhfpZ286VTp7lfh9PY2JYOF._i TLK8x2QIyxRlxXauJL9dkPJyjZRZKG9XJwNYTmgyJ7C.cx3Sa_Xg6q.p4XmM2Ryfeji3cn1WQDGM nKQJVrDQ_xFESMrBbbe.a3QNJ5HEMeAC_pPmZp4kkeDKpCVG.8ZAv6srLx7uIp94ojQIcrpEF.tr Bli4V8lU7vyqeBY9PJhlRe5dDSWJqCZ7CbixdnSrq4 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Fri, 18 Sep 2020 18:34:37 +0000 Original-Received: by smtp422.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID af085012336e8c77b7adfe0d4cda1222; Fri, 18 Sep 2020 18:34:32 +0000 (UTC) In-Reply-To: <20200918125424.GF635@breton.holly.idiocy.org> (Alan Third's message of "Fri, 18 Sep 2020 13:54:24 +0100") X-Mailer: WebService/1.1.16583 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Original-From: Xref: news.gmane.io gmane.emacs.bugs:188345 Archived-At: --=-=-= Content-Type: text/plain Alan Third writes: > > This looks good to me. I think we'll want to apply it to Emacs 27 > since this is a regression from Emacs 26 and the fix is minimal, so > can you please rebase against emacs-27 and I'll push it there. > > Thanks! Here's the same patch applied on top of the emacs-27 branch. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-modern-constant-names-for-the-NS-pasteboard.patch >From 4e3dc31ab100467fb39bce6e687aef029f0d3225 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Fri, 18 Sep 2020 13:36:47 +0200 Subject: [PATCH] Use modern constant names for the NS pasteboard Use the same pasteboard constant names defined in ns_drag_types. (Bug#43470). * src/nsterm.m: Rename NSURLPboardType to NSPasteboardTypeURL, NSStringPboardType to NSPasteboardTypeString, and NSTabularTextPboardType to NSPasteboardTypeTabularText --- src/nsterm.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index ac467840a2..3dd915e370 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -8363,7 +8363,7 @@ -(BOOL)performDragOperation: (id ) sender while ( (file = [fenum nextObject]) ) strings = Fcons (build_string ([file UTF8String]), strings); } - else if ([type isEqualToString: NSURLPboardType]) + else if ([type isEqualToString: NSPasteboardTypeURL]) { NSURL *url = [NSURL URLFromPasteboard: pb]; if (url == nil) return NO; @@ -8372,8 +8372,8 @@ -(BOOL)performDragOperation: (id ) sender strings = list1 (build_string ([[url absoluteString] UTF8String])); } - else if ([type isEqualToString: NSStringPboardType] - || [type isEqualToString: NSTabularTextPboardType]) + else if ([type isEqualToString: NSPasteboardTypeString] + || [type isEqualToString: NSPasteboardTypeTabularText]) { NSString *data; -- 2.28.0 --=-=-=--