From: Unknown <unknown@unknown.invalid>
To: Alan Third <alan@idiocy.org>
Cc: "Paul Magwene, Ph.D." <paul.magwene@duke.edu>, 43470@debbugs.gnu.org
Subject: bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX
Date: Fri, 18 Sep 2020 20:34:30 +0200 [thread overview]
Message-ID: <m17dsr0w95.fsf@yahoo.es> (raw)
In-Reply-To: <20200918125424.GF635@breton.holly.idiocy.org> (Alan Third's message of "Fri, 18 Sep 2020 13:54:24 +0100")
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
Alan Third <alan@idiocy.org> writes:
>
> This looks good to me. I think we'll want to apply it to Emacs 27
> since this is a regression from Emacs 26 and the fix is minimal, so
> can you please rebase against emacs-27 and I'll push it there.
>
> Thanks!
Here's the same patch applied on top of the emacs-27 branch. Thanks.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Use-modern-constant-names-for-the-NS-pasteboard.patch --]
[-- Type: text/x-patch, Size: 1534 bytes --]
From 4e3dc31ab100467fb39bce6e687aef029f0d3225 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= <mardani29@yahoo.es>
Date: Fri, 18 Sep 2020 13:36:47 +0200
Subject: [PATCH] Use modern constant names for the NS pasteboard
Use the same pasteboard constant names defined in
ns_drag_types. (Bug#43470).
* src/nsterm.m: Rename NSURLPboardType to NSPasteboardTypeURL,
NSStringPboardType to NSPasteboardTypeString, and
NSTabularTextPboardType to NSPasteboardTypeTabularText
---
src/nsterm.m | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/nsterm.m b/src/nsterm.m
index ac467840a2..3dd915e370 100644
--- a/src/nsterm.m
+++ b/src/nsterm.m
@@ -8363,7 +8363,7 @@ -(BOOL)performDragOperation: (id <NSDraggingInfo>) sender
while ( (file = [fenum nextObject]) )
strings = Fcons (build_string ([file UTF8String]), strings);
}
- else if ([type isEqualToString: NSURLPboardType])
+ else if ([type isEqualToString: NSPasteboardTypeURL])
{
NSURL *url = [NSURL URLFromPasteboard: pb];
if (url == nil) return NO;
@@ -8372,8 +8372,8 @@ -(BOOL)performDragOperation: (id <NSDraggingInfo>) sender
strings = list1 (build_string ([[url absoluteString] UTF8String]));
}
- else if ([type isEqualToString: NSStringPboardType]
- || [type isEqualToString: NSTabularTextPboardType])
+ else if ([type isEqualToString: NSPasteboardTypeString]
+ || [type isEqualToString: NSPasteboardTypeTabularText])
{
NSString *data;
--
2.28.0
next prev parent reply other threads:[~2020-09-18 18:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 13:27 bug#43470: 27.1; Drag and Drop not working properly in 27.1 on OSX Paul Magwene, Ph.D.
2020-09-17 17:46 ` Alan Third
2020-09-17 18:12 ` Unknown
2020-09-17 19:46 ` Alan Third
2020-09-18 12:00 ` Unknown
2020-09-18 12:54 ` Alan Third
2020-09-18 18:34 ` Unknown [this message]
2020-09-18 19:11 ` Alan Third
2020-09-18 21:27 ` Paul Magwene
2020-09-18 22:15 ` Alan Third
2020-09-18 23:22 ` Paul Magwene, Ph.D.
2020-09-19 11:02 ` Unknown
2020-09-19 12:45 ` Unknown
2020-09-22 12:24 ` Alan Third
2020-09-26 11:39 ` Unknown
2020-09-27 9:59 ` Alan Third
2020-09-27 22:22 ` Unknown
2020-10-03 14:43 ` Alan Third
2020-09-26 11:39 ` Unknown
2020-09-19 14:08 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17dsr0w95.fsf@yahoo.es \
--to=unknown@unknown.invalid \
--cc=43470@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=paul.magwene@duke.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.