From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master d03677343e9: Pan during touch screen pinch gestures Date: Thu, 16 Nov 2023 10:45:25 +0100 Message-ID: References: <170010542404.8395.4861984251472262512@vcs2.savannah.gnu.org> <20231116033024.A8049C0C1B3@vcs2.savannah.gnu.org> <87o7fukpvt.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9874"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 16 10:46:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3YxO-0002Ns-8s for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Nov 2023 10:46:42 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3YwK-00073i-DP; Thu, 16 Nov 2023 04:45:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3YwF-00071Y-9P for emacs-devel@gnu.org; Thu, 16 Nov 2023 04:45:32 -0500 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3YwD-0001DX-Im for emacs-devel@gnu.org; Thu, 16 Nov 2023 04:45:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1700127928; bh=gpbEHMN/wyVSszLVndb+GBE2nifmq0cKuhHecKRMaBY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=LK8Pb2ZvA099pKu9DXwZqKd91c68shP+3miEBRMqJ2RHm28V1/iYPg82i2/xYQ0wG uuahvCSSMIU0Bhha4TNVd0jBgtIIsKqkmnpM2TOQlkQefaUVfOZkcm252bn3avPdhQ FavEjGkEL+cFbBnkv1Y/JjFkYjt+CMbYhJngA6rb3tyO4aM0CojUX/+cdNWLBp2xb/ aNwLbP1pD70MKbvDi8ZxYH4zXNJ+LdykFdH15cPSkW1oq25C5ceB3V5vCTQI8dmPrX hjwHw1ahrzVX6Ufpu2lEgA7Q9S+V/FwcVU4EIHQZoPQH6+S1aQDjRjrK+mSTVzQkuS Heemi2FjcNKHA== In-Reply-To: <87o7fukpvt.fsf@yahoo.com> (Po Lu's message of "Thu, 16 Nov 2023 17:29:26 +0800") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312791 Archived-At: Po Lu writes: > Eshel Yaron writes: > >>> (defcustom completion-preview-commands '(self-insert-command >>> insert-char >>> delete-backward-char >>> - backward-delete-char-untabify) >>> + backward-delete-char-untabify >>> + text-conversion) >>> "List of commands that should trigger completion preview." >>> :type '(repeat (function :tag "Command" :value self-insert-command)) >>> :version "30.1") >> >> Is `text-conversion` a command? I can't find such a command or >> function, even after rebuilding Emacs master following this commit. >> OTOH I see that there's an event called `text-conversion`, that triggers >> a command called `analyze-text-conversion`, so perhaps it's that command >> that should go on `completion-preview-commands`? > > Ah, sorry; that code should not have found its way into this commit. I > meant to commit this separately after testing it. > > I'll correct this forthwith. Thanks. FWIW I've now tested Completion Preview mode with the latest Android build after substituting `text-conversion` with `analyze-text-conversion` (as you did in the new commit), works nicely!