From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70589: [PATCH] Refine the Custom type of generated '*-modes' options Date: Fri, 26 Apr 2024 18:34:20 +0200 Message-ID: References: <86frv8z8zc.fsf@gnu.org> <865xw4z7bn.fsf@gnu.org> <86zftgxj75.fsf@gnu.org> Reply-To: Eshel Yaron Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23551"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70589@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 26 18:35:04 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0OXP-0005vM-5d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Apr 2024 18:35:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0OXA-00079Z-Ia; Fri, 26 Apr 2024 12:34:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0OX8-00079I-EI for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 12:34:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0OX8-0008SW-5f for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 12:34:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0OXQ-0004Q0-EY for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 12:35:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2024 16:35:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70589 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70589-submit@debbugs.gnu.org id=B70589.171414929716893 (code B ref 70589); Fri, 26 Apr 2024 16:35:04 +0000 Original-Received: (at 70589) by debbugs.gnu.org; 26 Apr 2024 16:34:57 +0000 Original-Received: from localhost ([127.0.0.1]:38322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0OXI-0004OL-AB for submit@debbugs.gnu.org; Fri, 26 Apr 2024 12:34:57 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16]:38740 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0OX3-0004Lj-HK for 70589@debbugs.gnu.org; Fri, 26 Apr 2024 12:34:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1714149262; bh=P98xwUHx5r+FKGlOLU4gy87N/fjX3/F8/J9RNQYmEK4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=B+fB3I2qnJ2zkDMa04ilWJVqhuN+b0HO/mwM9AmkGXKi3/Hb4WsV0pGXg/XT9JNLn SJbqk0Rh8zfWPqjvr/SzY8UPtcpl8tCcxyMPi6ENTpdzZ0O+z/jbIywulb9frw9wL5 hz7S6aZvxHQr7213qb+/KQCgwNdWRLspHBvm0IxEhceKYyi6yrr4VrQlP89ao7Muqt gtfvoIQ6xTWbsdSF7LUlbYVgRLxWe4JWg3Qqm3wK264IzGBp3oK4lFsho0AtxBJQJl wkGXwcLTsI5vBm+1IRx+lm3RXDzPbpGXsrVALxbixXiXOpt4D/Tl3qEhl17bYccxDt O3g3W9X8er6QQ== In-Reply-To: <86zftgxj75.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Apr 2024 18:00:30 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283999 Archived-At: Eli Zaretskii writes: >> From: Eshel Yaron >> Cc: 70589@debbugs.gnu.org, monnier@iro.umontreal.ca >> Date: Fri, 26 Apr 2024 14:24:42 +0200 >> >> >> These are slightly different: a value of t ("Enable in all major modes") >> >> says to enable everywhere, while a t inside a list ("All major modes") >> >> says to enable in modes that were not mentioned earlier in the list (so >> >> putting t in the end of the list means "otherwise, enable"). Similarly >> >> for the "none" alternatives: a value of nil ("Don't enable...") means we >> >> never enable the minor mode, while the effect of a nil inside the list >> >> is relative to the previous elements, and means "otherwise, don't". >> >> Does that make sense? >> > >> > It might make sense, if we change the labels to say what you tell >> > above. >> > >> > Thanks. >> >> OK, here's an updated patch with revised labels: > > Thanks, but I find the likes of "By default, enable" not clear enough. > Would it be accurate to say this instead: > > (const :tag "Enable in any other mode" t) > (const :tag "Don't enable in the other modes" nil) That could also work, but I think this wording is a bit confusing when entering the first list element (so there are no "other mode/s" yet). If you think it's nevertheless preferable, I don't object.