From: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 71117@debbugs.gnu.org,
"Andreas Röhler" <andreas.roehler@easy-emacs.de>,
"Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Subject: bug#71117: 30.0.50; output of describe-function
Date: Thu, 23 May 2024 13:51:02 +0200 [thread overview]
Message-ID: <m17cfk6921.fsf@dazzs-mbp.kpn> (raw)
In-Reply-To: <86o78xks79.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 23 May 2024 09:28:46 +0300")
Hi Juri,
Juri Linkov <juri@linkov.net> writes:
>>> May it be possible to switch the button, like:
>>>
>>> "list is defined in ‘C source code’, a ‘primitive-function’".
>>
>> Might you be interested in 's', bound to 'help-view-source'? Won't
>> solve the "force-of-habit" problem, but I find it rather convenient: no
>> need to TAB to the button; hopefully future-proof as redesigns wash over
>> *Help*. I've found it worth the brain re-wiring.
>
> Except there is a bug that prevents 's' from handling some C variables, e.g.:
>
> 0. emacs -Q
> 1. C-h v minibuffer-allow-text-properties RET
> 2. s
>
> fails with
>
> (error "Don’t know where ‘minibuffer-allow-text-properties’ is defined")
>
> So still need to use 'TAB RET' to navigate to C source.
That bothered me too. Does this patch help?
diff --git a/lisp/help-mode.el b/lisp/help-mode.el
index 48433d899ab..e16408be7b0 100644
--- a/lisp/help-mode.el
+++ b/lisp/help-mode.el
@@ -265,7 +265,9 @@ help-function-def--button-function
(require 'find-func)
(when (eq file 'C-source)
(setq file
- (help-C-file-name (indirect-function fun) 'fun)))
+ (if (memq type '(variable defvar))
+ (help-C-file-name fun 'var)
+ (help-C-file-name (indirect-function fun) 'fun))))
;; Don't use find-function-noselect because it follows
;; aliases (which fails for built-in functions).
(let* ((location
next prev parent reply other threads:[~2024-05-23 11:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 13:53 bug#71117: 30.0.50; output of describe-function Andreas Röhler
2024-05-22 14:10 ` Eli Zaretskii
2024-05-22 17:46 ` Kévin Le Gouguec
2024-05-22 18:24 ` Eli Zaretskii
2024-05-22 22:22 ` Kévin Le Gouguec
2024-05-23 5:25 ` Eli Zaretskii
2024-05-28 17:44 ` Andrea Corallo
2024-05-28 18:20 ` Eli Zaretskii
2024-05-28 19:42 ` Andrea Corallo
2024-05-28 22:04 ` Kévin Le Gouguec
2024-05-28 22:25 ` Andrea Corallo
2024-05-29 11:25 ` Eli Zaretskii
2024-05-29 15:17 ` Andrea Corallo
2024-05-29 15:54 ` Eli Zaretskii
2024-05-29 16:04 ` Andrea Corallo
2024-05-29 11:38 ` Eli Zaretskii
2024-05-23 6:28 ` Juri Linkov
2024-05-23 11:51 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-23 17:20 ` Juri Linkov
2024-05-23 20:23 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m17cfk6921.fsf@dazzs-mbp.kpn \
--to=bug-gnu-emacs@gnu.org \
--cc=71117@debbugs.gnu.org \
--cc=andreas.roehler@easy-emacs.de \
--cc=juri@linkov.net \
--cc=kevin.legouguec@gmail.com \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.