vc-annotate causes Emacs to die

vc-annotate causes Emacs to die

[Robert J. Chassell]

In today's CVS snapshot, Tue, 2002 Jul 23  13:05 UTC,
GNU Emacs 21.3.50.123 (i686-pc-linux-gnu, X toolkit).
Emacs started with:

    emacs -q --no-site-file --eval '(blink-cursor-mode 0)'

`C-x v g' (vc-annotate) causes Emacs to die.

To reproduce, visit:

    emacs/lisp/etc/NEWS
or 
    emacs/lisp/calendar/solar.el

and give the vc-annotate command `C-x v g'


The backtrace is:

#0  0x080aad1e in x_fill_glyph_string (s=0xbfffe874, face_id=12, start=35, 
    end=80, overlaps_p=0) at xterm.c:1420
#1  0x080ab615 in x_draw_glyphs (w=0x82d53e8, x=305, row=0x84f7b9c, 
    area=TEXT_AREA, start=0, end=80, hl=DRAW_NORMAL_TEXT, overlaps_p=0)
    at xterm.c:5142
#2  0x080adee6 in x_write_glyphs (start=0x8528a98, len=80) at xterm.c:5339
#3  0x08053c4c in update_text_area (w=0x82d53e8, vpos=3) at dispnew.c:4265
#4  0x08054082 in update_window_line (w=0x82d53e8, vpos=3, 
    mouse_face_overwritten_p=0xbfffec68) at dispnew.c:4489
#5  0x080539eb in update_window (w=0x82d53e8, force_p=0) at dispnew.c:4145
#6  0x0805347b in update_window_tree (w=0x84bb258, force_p=0) at dispnew.c:3879
#7  0x08053466 in update_window_tree (w=0x84c4420, force_p=0) at dispnew.c:3877
#8  0x08053385 in update_frame (f=0x84484b0, force_p=0, inhibit_hairy_id_p=0)
    at dispnew.c:3816
#9  0x08067224 in redisplay_internal (preserve_echo_area=0) at xdisp.c:8964
#10 0x0806617c in redisplay () at xdisp.c:8374
#11 0x080d6075 in read_char (commandflag=1, nmaps=2, maps=0xbffff424, 
    prev_event=405373956, used_mouse_menu=0xbffff470) at keyboard.c:2323
#12 0x080dccb0 in read_key_sequence (keybuf=0xbffff574, bufsize=30, 
    prompt=405373956, dont_downcase_last=0, can_return_switch_frame=1, 
    fix_current_buffer=1) at keyboard.c:8363
#13 0x080d4be8 in command_loop_1 () at keyboard.c:1470
#14 0x08128159 in internal_condition_case (bfun=0x80d48e0
    <command_loop_1>
    handlers=405470516, hfun=0x80d44f4 <cmd_error>) at eval.c:1349
#15 0x080d47b8 in command_loop_2 () at keyboard.c:1271
#16 0x08127ced in internal_catch (tag=405431844, 
    func=0x80d4794 <command_loop_2>, arg=405373956) at eval.c:1109
#17 0x080d4763 in command_loop () at keyboard.c:1250
#18 0x080d42b0 in recursive_edit_1 () at keyboard.c:966
#19 0x080d43e0 in Frecursive_edit () at keyboard.c:1022
#20 0x080d32b3 in main (argc=5, argv=0xbffffb34, envp=0xbffffb4c)
    at emacs.c:1625


-- 
    Robert J. Chassell                  bob@rattlesnake.com
    Rattlesnake Enterprises             http://www.rattlesnake.com

[spiegel@gnu.org: Re: [Fwd: vc-annotate causes Emacs to die]]

[Richard Stallman]

Can you help fix this bug in redisplay?

------- Start of forwarded message -------
Subject: Re: [Fwd: vc-annotate causes Emacs to die]
From: Andre Spiegel <spiegel@gnu.org>
To: Stefan Monnier <monnier@cs.yale.edu>
Cc: rms@gnu.org, bob@rattlesnake.com, billw@wolfram.com
In-Reply-To: <200208090636.g796aNY11313@rum.cs.yale.edu>
Date: 23 Aug 2002 14:37:02 +0200
X-Spam-Status: No, hits=-3.1 required=5.0
	tests=IN_REP_TO,WEIRD_PORT
	version=2.31
X-Spam-Level: 

Hi Stefan,

since the time when you made vc-annotate use jit-lock, using it causes a
segfault for many users.  You wrote:

> It's unrelated to VC since it's a bug in the C code.

This is of course true, but vc-annotate still used to work prior to your
modification.  I'm not qualified to have a look at the C level problem,
and it would take me a lot of time to catch up on this.  Can you point
me to someone who would be more qualified to do it (I'm including the
segfault stack trace below)?  If not, I suggest reverting vc-annotate to
the way it was before your change, until somebody finds the time to fix
the C code.

Here's the stack trace (taken from Bob's message):

#0  0x080aad1e in x_fill_glyph_string (s=0xbfffe874, face_id=12,
start=35, 
    end=80, overlaps_p=0) at xterm.c:1420
#1  0x080ab615 in x_draw_glyphs (w=0x82d53e8, x=305, row=0x84f7b9c, 
    area=TEXT_AREA, start=0, end=80, hl=DRAW_NORMAL_TEXT, overlaps_p=0)
    at xterm.c:5142
#2  0x080adee6 in x_write_glyphs (start=0x8528a98, len=80) at
xterm.c:5339
#3  0x08053c4c in update_text_area (w=0x82d53e8, vpos=3) at
dispnew.c:4265
#4  0x08054082 in update_window_line (w=0x82d53e8, vpos=3, 
    mouse_face_overwritten_p=0xbfffec68) at dispnew.c:4489
#5  0x080539eb in update_window (w=0x82d53e8, force_p=0) at
dispnew.c:4145
#6  0x0805347b in update_window_tree (w=0x84bb258, force_p=0) at
dispnew.c:3879
#7  0x08053466 in update_window_tree (w=0x84c4420, force_p=0) at
dispnew.c:3877
#8  0x08053385 in update_frame (f=0x84484b0, force_p=0,
inhibit_hairy_id_p=0)
    at dispnew.c:3816
#9  0x08067224 in redisplay_internal (preserve_echo_area=0) at
xdisp.c:8964
#10 0x0806617c in redisplay () at xdisp.c:8374
#11 0x080d6075 in read_char (commandflag=1, nmaps=2, maps=0xbffff424, 
    prev_event=405373956, used_mouse_menu=0xbffff470) at keyboard.c:2323
#12 0x080dccb0 in read_key_sequence (keybuf=0xbffff574, bufsize=30, 
    prompt=405373956, dont_downcase_last=0, can_return_switch_frame=1, 
    fix_current_buffer=1) at keyboard.c:8363
#13 0x080d4be8 in command_loop_1 () at keyboard.c:1470
#14 0x08128159 in internal_condition_case (bfun=0x80d48e0
    <command_loop_1>
    handlers=405470516, hfun=0x80d44f4 <cmd_error>) at eval.c:1349
#15 0x080d47b8 in command_loop_2 () at keyboard.c:1271
#16 0x08127ced in internal_catch (tag=405431844, 
    func=0x80d4794 <command_loop_2>, arg=405373956) at eval.c:1109
#17 0x080d4763 in command_loop () at keyboard.c:1250
#18 0x080d42b0 in recursive_edit_1 () at keyboard.c:966
#19 0x080d43e0 in Frecursive_edit () at keyboard.c:1022
#20 0x080d32b3 in main (argc=5, argv=0xbffffb34, envp=0xbffffb4c)
    at emacs.c:1625
------- End of forwarded message -------

Re: [spiegel@gnu.org: Re: [Fwd: vc-annotate causes Emacs to die]]

[Gerd Moellmann]

Richard Stallman <rms@gnu.org> writes:

> Can you help fix this bug in redisplay?
> 
> From: Andre Spiegel <spiegel@gnu.org>
> Subject: Re: [Fwd: vc-annotate causes Emacs to die]
> To: Stefan Monnier <monnier@cs.yale.edu>
> Cc: rms@gnu.org, bob@rattlesnake.com, billw@wolfram.com
> Date: 23 Aug 2002 14:37:02 +0200
> 
> Hi Stefan,
> 
> since the time when you made vc-annotate use jit-lock, using it causes a
> segfault for many users.  You wrote:
> 
> > It's unrelated to VC since it's a bug in the C code.
> 
> This is of course true, but vc-annotate still used to work prior to your
> modification. 

Can someone tell me what modification that is?

What's the recipe to reproduce this?  And with which version of Emacs?

Re: vc-annotate causes Emacs to die

[Andre Spiegel]

On Mon, 2002-08-26 at 15:33, Gerd Moellmann wrote:

> Can someone tell me what modification that is?
> 
> What's the recipe to reproduce this?  And with which version of Emacs?

On 2002-07-16, Stefan changed vc-annotate to use jit-lock.  Since then,
vc-annotate (C-x v g) on a CVS-controlled file seems to fail with a
segfault for several people.  For my own part, I'm getting a segfault
all the time, even with -q --no-sitefile.  This is current CVS Emacs,
with a dark background and orange text using a neep font.