From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Liu Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string Date: Wed, 27 Apr 2016 22:23:16 +0800 Message-ID: References: <20160427051934.30651.96563@vcs.savannah.gnu.org> <60a6de33-1bc9-b5e4-82b9-c1a26d655a94@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461767055 21886 80.91.229.3 (27 Apr 2016 14:24:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Apr 2016 14:24:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Apr 27 16:24:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1avQNj-0006F4-1S for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 16:23:59 +0200 Original-Received: from localhost ([::1]:43518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avQNd-0001zr-7P for ged-emacs-devel@m.gmane.org; Wed, 27 Apr 2016 10:23:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avQNI-0001qp-66 for emacs-devel@gnu.org; Wed, 27 Apr 2016 10:23:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avQNF-0003PJ-0x for emacs-devel@gnu.org; Wed, 27 Apr 2016 10:23:32 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:37436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avQNE-0003P2-Qh for emacs-devel@gnu.org; Wed, 27 Apr 2016 10:23:28 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1avQNC-00064N-ES for emacs-devel@gnu.org; Wed, 27 Apr 2016 16:23:27 +0200 Original-Received: from 221.222.159.253 ([221.222.159.253]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Apr 2016 16:23:26 +0200 Original-Received: from sdl.web by 221.222.159.253 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 27 Apr 2016 16:23:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 15 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.222.159.253 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (OS X 10.11.4) Cancel-Lock: sha1:V95q+qV5espIWrLJDwsizr46HjU= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203389 Archived-At: On 2016-04-27 12:40 +0300, Dmitry Gutov wrote: > Why was that bad? > > vc-working-revision also caches the result, and > vc-git-working-revision does not. Do you want Emacs to call Git > multiple times per second? Thanks, I hadn't paid attention to the cache issue. I pushed a different fix that doesn't bypass the cache. We need to avoid deciding the backend at that point and vc-git-mode-line-string expects REV to be non-nil or the substring form will complain. Leo