all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Liu <sdl.web@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string
Date: Wed, 27 Apr 2016 22:23:16 +0800	[thread overview]
Message-ID: <m160v3gmgb.fsf@zeuss-MBP.lan> (raw)
In-Reply-To: 60a6de33-1bc9-b5e4-82b9-c1a26d655a94@yandex.ru

On 2016-04-27 12:40 +0300, Dmitry Gutov wrote:
> Why was that bad?
>
> vc-working-revision also caches the result, and
> vc-git-working-revision does not. Do you want Emacs to call Git
> multiple times per second?

Thanks, I hadn't paid attention to the cache issue. I pushed a different
fix that doesn't bypass the cache.

We need to avoid deciding the backend at that point and
vc-git-mode-line-string expects REV to be non-nil or the substring form
will complain.

Leo




  reply	other threads:[~2016-04-27 14:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160427051934.30651.96563@vcs.savannah.gnu.org>
     [not found] ` <E1avHst-0007zE-3Z@vcs.savannah.gnu.org>
2016-04-27  9:40   ` [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string Dmitry Gutov
2016-04-27 14:23     ` Leo Liu [this message]
2016-04-27 14:55       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m160v3gmgb.fsf@zeuss-MBP.lan \
    --to=sdl.web@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.