From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel =?UTF-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62238: 30.0.50; Unusual interpretation of "S-expressions" in c-ts-mode Date: Sat, 18 Mar 2023 13:11:15 +0100 Message-ID: References: <87ilezg0wo.fsf@posteo.net> <7FDC4392-AC34-4EA2-A166-AB10755361CD@gmail.com> Reply-To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) Cc: 62238@debbugs.gnu.org, Philip Kaludercic , theodor thornhill To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 13:12:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdVQD-0004Gj-FK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 13:12:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdVPp-00016G-FP; Sat, 18 Mar 2023 08:12:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdVPm-00015U-Vw for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 08:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdVPm-0003aj-NZ for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 08:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdVPm-0001Mh-Fa for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 08:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 12:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62238 X-GNU-PR-Package: emacs Original-Received: via spool by 62238-submit@debbugs.gnu.org id=B62238.16791414925204 (code B ref 62238); Sat, 18 Mar 2023 12:12:02 +0000 Original-Received: (at 62238) by debbugs.gnu.org; 18 Mar 2023 12:11:32 +0000 Original-Received: from localhost ([127.0.0.1]:46471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdVPI-0001Ls-Eb for submit@debbugs.gnu.org; Sat, 18 Mar 2023 08:11:32 -0400 Original-Received: from sonic301-21.consmr.mail.ir2.yahoo.com ([77.238.176.98]:41135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdVPF-0001Ld-Nt for 62238@debbugs.gnu.org; Sat, 18 Mar 2023 08:11:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1679141481; bh=IfjpucQohfnXxzTeuESVZbVgeqbl4UTfy2eOXf/2H2U=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=pXVvfEpb+UX/s3iKOTGBtyIB86v3z/SZc155XPmRY7FustbHnZgaoQlFxplnExQH4qrC8bA5DrRNnRQJEhYrTrda3oZ6qaQHeXdBHgMfJ7Lc5YxRechmY63yln5BTTYgxBiAesfO0Xt0qCMtqJIFjHLSwKejPcUgHv+R/0LSkb75fQq9o2RTlKRGKs3vMzpS4l/PA1Uigvq0DTH3qsRW+YdvkpK1ls24PQ2LLkug79sOSjOT/SzzekMnQXkVbEc9fRbuB8Vp09rcusKP/qeu4wpRRTvOOLLIOgGCG6aaYFrsINWfnnvbNSX5UlcFU1MDduDWHZjxqaMH0bRppEgXJg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1679141481; bh=ww1108trP89/A9AevvO4qqg+O8JEoyz07nLhGKLN2Dz=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=aI72WV2MLuu9vLz/qpJIcaKjskTEwwd6YBJAbl6PVOAmbWFjMmUesb0RABfPyc1NE7sZERQ9yxDw3mc5SJtzgJHDT+y/G6TFlOFX5myqK7KIghZb7XY9jDlccZCI+8FkllQC34JdJvn721sc6/U7M/IVrYloULJjEQltdwea120iH69sshKc7NpusGCH64Acl6nFBhcyaaZOv9ATDfE45eX6px8NdYRRnYzu8Y0b9n781ehGm5Cjyt6/OjQzo5OanhUxkyz9ZET0urnc6tMjRK02gInydzsCcEWoxqC72ZTopDip6Ck7ykMfW5k2brzXF8/rMcMfh/betfntNA5Qgg== X-YMail-OSG: o3yXTyMVM1kp7zthF1DtA40UmBlSXwpVthYJSaHQ1bDTVOfyTZlOdeMpLeqhfCf wcFMytIJZV_HM04.qOrjlk8_hNNTWyV7hNyb9oQ1aT1mBKeioQCVixVjG9mX05AtpwcksCGNtZD6 Ro8qV7OJt_v5SZ9yFjpl8Zlr3QQyqsIepAUOU5q3v7dwgDxq5JF9TZw3s9xo8W9u3erEtsD0gNHQ ikwdATJ9fzpzD9L6p40cR8FP.gijJYCdB_0.UllZp44wMlHedE0gy1NCQj7U_ZofPEvT0n0Z18dE SOvTZA1lp1twRauDJ22UumJSYPttU9HbjmCdPAhvL7L2yW36yTDxabgVwgtPDzkdTYfqmBhzUZ32 bf8KIcRP2G03eNMsa6RgyxHMHw3oixMg.zCUCNx.CXS07J0w1TN8j1pM7N7pm.3Wdb.aj71at.Ci zY6vXU6FL4DUzim8NNdEnVC9Kep.c1Frpw3OEk6unWi_VJko3FVrg529iK16ST4nNLj6sQogXuLv ZCU0UF1OmpbzBeyRQ1myYHzVdFXHLqCFEt3aze3Ty8E8jGY98DUnppnApqWkXKw.jZrTVlvyJbhz KpVeHGvS67pylCZOGzdKTIz72vg20b1.iyQQZVmpOYQnquRnaYfl005SqId8mvJDowQ7QLhYanrD oUHhywXODF2AnszO.Xl7BzCvfkVo4pRX6OF9f7U_QKBqcmpV4JVzmHtU_PS9KGmPPboSNyYLu11j HmAM_M6Q5FgPidX4u9mIFb0HFCxL_e_Jwrzk8CRu8CKudzzB5yH7BDPBwWc1guaLZ_JUWRglwzwq jEpOHDO5pXP3M8OvgzSFE.LkhrSPu80M40qBnj_HYe X-Sonic-MF: X-Sonic-ID: 92776d4c-f0bc-437c-9285-c5e1d9d31184 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Sat, 18 Mar 2023 12:11:21 +0000 Original-Received: by hermes--production-ir2-5b7d458747-lqssg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f1e1c915e86209d029182a16e0095e86; Sat, 18 Mar 2023 12:11:17 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?="'s message of "Sat, 18 Mar 2023 11:29:55 +0100") X-Mailer: WebService/1.1.21311 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258168 Archived-At: Daniel Mart=C3=ADn writes: > Yuan Fu writes: > >> >> I tested this on my Emacs session and vanilla session, and both marked >> to the closing bracket. I believe forward-sexp should just work by the >> syntax table. Perhaps it=E2=80=99s your config or something? >> > > You need to enable c-ts-mode first, which redirects > forward-sexp-function to treesit-forward-sexp. I see in treesit.el that we set forward-sexp-function to treesit-forward-sexp when treesit-sexp-type-regexp is set by the major mode. For languages with simple grammars, like C, I think that the current approach that uses the syntax table is simpler and less prone to errors, because the Tree-sitter function is general and should work for every language. I'd suggest we don't define treesit-sexp-type-regexp in c-ts-mode, at least for C. For languages like TypeScript, whose grammar is more complex, perhaps forward-sexp does not work very well and using Tree-sitter to implement it gives better results with code that is simpler to understand. Thanks.