From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: Another bug with the macro counter Date: Sat, 30 Oct 2004 00:06:11 -0400 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <200410210107.i9L176B10842@raven.dms.auburn.edu> <200410300238.i9U2cOD02290@raven.dms.auburn.edu> <200410300327.i9U3RWW02355@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099109653 15370 80.91.229.6 (30 Oct 2004 04:14:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 30 Oct 2004 04:14:13 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 30 06:14:03 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CNkcs-0003ec-00 for ; Sat, 30 Oct 2004 06:14:02 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CNkkl-0007zp-2G for ged-emacs-devel@m.gmane.org; Sat, 30 Oct 2004 00:22:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CNkkb-0007zj-6w for emacs-devel@gnu.org; Sat, 30 Oct 2004 00:22:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CNkka-0007zX-J2 for emacs-devel@gnu.org; Sat, 30 Oct 2004 00:22:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CNkka-0007zU-H4 for emacs-devel@gnu.org; Sat, 30 Oct 2004 00:22:00 -0400 Original-Received: from [206.47.199.166] (helo=simmts8-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CNkVK-0003zU-FK for emacs-devel@gnu.org; Sat, 30 Oct 2004 00:06:15 -0400 Original-Received: from empanada.home ([67.71.25.5]) by simmts8-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20041030040612.KXKE1692.simmts8-srv.bellnexxia.net@empanada.home>; Sat, 30 Oct 2004 00:06:12 -0400 Original-Received: by empanada.home (Postfix, from userid 502) id ECE8C3472B1; Sat, 30 Oct 2004 00:06:11 -0400 (EDT) Original-To: Luc Teirlinck In-Reply-To: <200410300327.i9U3RWW02355@raven.dms.auburn.edu> (Luc Teirlinck's message of "Fri, 29 Oct 2004 22:27:32 -0500 (CDT)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (darwin) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29164 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29164 > *************** > *** 865,873 **** > (if (and (integerp value) > (or (not (memq this-command '(eval-last-sexp eval-print-last-sexp))) > (eq this-command last-command) > ! (and (boundp 'edebug-active) edebug-active))) > (let ((char-string > ! (if (or (and (boundp 'edebug-active) edebug-active) > (memq this-command '(eval-last-sexp eval-print-last-sexp))) > (prin1-char value)))) > (if char-string > --- 865,874 ---- > (if (and (integerp value) > (or (not (memq this-command '(eval-last-sexp eval-print-last-sexp))) > (eq this-command last-command) > ! (and (boundp 'edebug-active) (with-no-warnings edebug-active)))) > (let ((char-string > ! (if (or (and (boundp 'edebug-active) > ! (with-no-warnings edebug-active)) > (memq this-command '(eval-last-sexp eval-print-last-sexp))) > (prin1-char value)))) > (if char-string I believe replacing (and (boundp 'foo) foo) with (if (boundp 'foo) foo) is a better choice because it removes the warning wihtout cluttering the code and without introducing compatibility problems with older Emacsen. Stefan