From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Daniel_Mart=C3=ADn?= Newsgroups: gmane.emacs.devel Subject: Handling of [mouse-movement] and exiting isearch Date: Mon, 09 Nov 2020 01:09:50 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23638"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (darwin) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 01:11:38 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbumY-00063i-BC for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 01:11:38 +0100 Original-Received: from localhost ([::1]:44128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbumX-0004xP-ER for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Nov 2020 19:11:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbul2-0003ug-Uv for emacs-devel@gnu.org; Sun, 08 Nov 2020 19:10:05 -0500 Original-Received: from sonic311-32.consmr.mail.ir2.yahoo.com ([77.238.176.164]:37751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbukx-0004s5-Um for emacs-devel@gnu.org; Sun, 08 Nov 2020 19:10:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1604880595; bh=Exq0JgD0hNsEYZWqvuoPUGoQ2kATJdzSqZ1xDp+ga1M=; h=From:To:Subject:Date:References:From:Subject; b=jf6+QPfVFsmUVgeIQMIVysyUOpecAYwxXHlXfyWK19Jcn9/aHbYUPLuBnL8T9NI5m17F5W5x5A+/3mdUYbP/NmbcluYqfMAdWftxqjp9D8ajlqtpCCBSp4WFZZsw7In6NxXy0IOyne4DCTHonZxOw+DWbrLpDJIJYt5MhAW1RdBvzMwb4BWhCnaMaYEec+D9sAufwNHl+ynG3SH10SzmFxhGgZ4aC5BW2E2yVholn5VbpeJ0MaC7BKAsFxWDEIX1bsPkjlUGxsvFvZzZwe30BVMpMN1zui57UjZntTUxL6KauvhEuhvT2A3LcBMFUwvKoxS/qiDd/+jrOD3H1Qo8EA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1604880595; bh=PyUMLUIfw1JOkuW+glsv7xIugG5Prj5g767aEuN8tDr=; h=From:To:Subject:Date; b=H3YTsLGY5VNdXaIGM08ip/nYRVX3ewm78SpfyML5ANQx9EAydUJCXfuPRN3J/mPYEZvtJw/dZZyw7Jea7OYFXiMt73ZHekLswy/KjxFG6JMN9iu7jXKh63nkxLZreoNf+1S01ZxJWImswbAaepFuidSvB3/BIRxrgCWW0Oqh2kDeLCk5jAsCKSWTySHeXjVnLPGQt2qXHEbCChnE93qEKZh+l3PFp8epLdLZq3vJ+KARqs7Aq6eiy4CLNXazExS5ebLZuJKPg9Awoi6eA3+D6CwGCq8OAk0m865aHXgX2Oa85kqR9EDKLQ7zFlpVJcWg+zYtgagGK3WBr984WIgepQ== X-YMail-OSG: Wz_o5jUVM1nEtUJsWaH3tUDLGaDtMSVsSocr8NgW52oJjOqfNBFAKKjElORS9_s AIHP6SKUdP4BI08f6gMviaA3l4jCdmX0KqaNlYqgyHjHkvjknbEDpAAee9SjGSIvJvgljcmHw_G8 qgMEc.NzrOnJEKXLN7rTSu0apFoicnbS_XrnNwv06uRJtmZnIgU1TuO.VJW_0EQkPL6RLWdKyUG. q_kqkjbtRijMldL4kuGgkuhiKok8njO8FjnuqpVzO5_2nvGWUemXhoeZ94Ww6PzMb1h7cAZifhy1 JSk8P94vIWab0mgs0N.oLIT50M6y86IkXerolLaNq3_.6e33fEOgPSS3OC.sjHyOaFZxMYrqvfxM Vei4eqvLSuGmE_6uMYxnkvXYkGB54TrUy_q3ErZwuZGatNvYIIA1PDfdEZWvcwYMZjQtGGkLEIWl ziH.4NUF9.p8fsn8F3qIjfs5GSW52yP_tzZmxMoghJlAsF8ZKWPTbn7Wh9YhR4Zs.eqLUQyuDhTR cIQ8Wq_8Q0hB9_RPGX6x2r2Zeozg5r0Z_eKFIzNvqTiSr2YXa2qSQgj20hfiTtB2w2lV.GKdXIOA FiqCSHoOjMkQX01T73nxKALfcV9kPv3e2CbxZSwmikQcBG2tRys1vUBmFGQLV6XCyMI0bZ_diLER X9rzQwd6477XTkHioqHn0792ul5dOWqIY1R7H2NPrwiix8tsHtAJV1.mYGzcrIyugb5mAGhhrAe3 C00nGkF5C.Wt4LEbAv914cjgNRTwkErjaJw7CQ6zm85HwfhEYUWqt9uBJHHQpn.zNcVedwhdxlDt i9SOpJgDwJrEOtaJuIntpeijQJYUJe9MFK0Voes_69 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Mon, 9 Nov 2020 00:09:55 +0000 Original-Received: by smtp410.mail.ir2.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 7477c5632b7415fa117b9bff5a438265; Mon, 09 Nov 2020 00:09:51 +0000 (UTC) X-Mailer: WebService/1.1.16944 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Apache-HttpAsyncClient/4.1.4 (Java/11.0.8) Received-SPF: pass client-ip=77.238.176.164; envelope-from=mardani29@yahoo.es; helo=sonic311-32.consmr.mail.ir2.yahoo.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/08 19:09:55 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258931 Archived-At: I'd like commands bound to [mouse-movement] to not exit isearch, and I'm confused by this code in isearch.el: ;; Pass frame events transparently so they won't exit the search. ;; In particular, if we have more than one display open, then a ;; switch-frame might be generated by someone typing at another keyboard. (define-key map [switch-frame] nil) (define-key map [delete-frame] nil) (define-key map [iconify-frame] nil) (define-key map [make-frame-visible] nil) (define-key map [mouse-movement] nil) (define-key map [language-change] nil) The comment seems to imply that [mouse-movement], [language-change] and some frame-related events won't exit isearch. However, the code is calling define-key and passsing KEY as nil, which means that the events will be undefined in isearch-mode-map, which by default means that they _will_ exit isearch, right? I think the code that implements this logic is in function isearch-pre-command-hook: ;; Don't exit Isearch for isearch key bindings. ((or (commandp (lookup-key isearch-mode-map key nil)) (commandp (lookup-key `(keymap (tool-bar menu-item nil ,isearch-tool-bar-map)) key)))) What am I missing? I'm not sure if making [mouse-movement] not exit isearch worked in the past but has regressed in recent versions of Emacs, or if I'm not understanding the logic correctly. Thanks.