From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eshel Yaron Newsgroups: gmane.emacs.devel Subject: Re: master 9904376c797: Support calling 'project-current' with custom prompt Date: Wed, 23 Oct 2024 08:54:55 +0200 Message-ID: References: <172834239339.3048552.12080367051270999761@vcs3.savannah.gnu.org> <20241007230633.CC7E91EAF92@vcs3.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16366"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 23 08:55:49 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3VHZ-00045W-Sj for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Oct 2024 08:55:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3VGp-0008KM-2g; Wed, 23 Oct 2024 02:55:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3VGn-0008Jd-9E for emacs-devel@gnu.org; Wed, 23 Oct 2024 02:55:01 -0400 Original-Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3VGl-0002nN-SD for emacs-devel@gnu.org; Wed, 23 Oct 2024 02:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1729666497; bh=xFp0t1/9HF4/ikgkqYQLFNEbmLBRIm8Rnu1Jsdx85nI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=M1TEZ8yVLyb9CZYfr/TXcrczFw1jMDvd7b2t6GjqqRnkT2tdSUNz0FLe8y2vfMmtl 8IbnnaDg11EHqJPirq1UPqjIaf5ow7/5usezwZa8ZUSTZci1J9fxazmgX7zsH1FPqk I26MOi0JWaP0BBpnDzgyWLYwrAVIK2uGon/xGJuXlF5tke0uxxOLDRMbMF5l481Oht xdjp8OCO2rf5T53oKiESBpt2QRNkbYCngpa4zG3m08wXq6o7m67j6vOfRngyinWYCd QfNC2pY5ayNLNmR3cS+ngUvyTDapQboud3gTy0iS2oZFdxgGRogTQMr6QAllA080Vq XMwLaNVWyRoVg== In-Reply-To: <20241007230633.CC7E91EAF92@vcs3.savannah.gnu.org> (Dmitry Gutov's message of "Mon, 7 Oct 2024 19:06:33 -0400 (EDT)") Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324764 Archived-At: Hi Dmitry, Dmitry Gutov writes: > branch: master > commit 9904376c797665de47ff760bcf8c2fe33d7ae625 > Author: Dmitry Gutov > Commit: Dmitry Gutov > > Support calling 'project-current' with custom prompt > [...] > - (setq directory (funcall project-prompter) > + (setq directory (if (stringp maybe-prompt) > + (funcall project-prompter maybe-prompt) > + (funcall project-prompter)) JFYI, I'm using a custom project-prompter, which was not prepared to be called with an argument, so I got some unexpected errors until I realized what changed. A quick lookup online shows that although this option is quite new, a few others already set it to a custom function, so it might be worth catching the "Wrong number of arguments" error. Also, I'd like to update the docstring of project-prompter along the following lines, if it looks right to you: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 3cdaa7c2a76..6383bdc95d2 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -199,7 +199,9 @@ project-current-directory-override (defcustom project-prompter #'project-prompt-project-dir "Function to call to prompt for a project. -Called with no arguments and should return a project root dir." +The function is either called with no arguments or with one argument, +which is the prompt string to use when prompting. It should return a +project root directory." :type '(choice (const :tag "Prompt for a project directory" project-prompt-project-dir) (const :tag "Prompt for a project name" Cheers, Eshel