From: Leo Liu <sdl.web@gmail.com>
To: 35286@debbugs.gnu.org
Subject: bug#35286: 26.2; indent-sexp broken
Date: Mon, 15 Apr 2019 20:14:58 +0800 [thread overview]
Message-ID: <m136mjzcql.fsf@gmail.com> (raw)
I am only using the following ruby code to demonstrate the issue. I
noticed this issue while editing other programming text.
def sum_eq_n?(arr, n)
return true if arr.empty? && n == 0
arr.product(arr).reject { |a,b| a == b }.any? !{ |a,b| a + b == n } #
def sum_eq_n?(arr, n)
return true if arr.empty? && n == 0
arr.product(arr).reject { |a,b| a == b }.any? { |a,b| a + b == n }
end
Put the above ruby code in a ruby-mode buffer. ! is used to indicate
where point is and is not part of the code.
M-x indent-sexp and see indentation of every line after the point
changed.
The bug is caused by the following unsafe part of indent-sexp introduced
in 26.2:
(save-excursion
(let ((eol (line-end-position)))
(forward-sexp 1)
(condition-case ()
(while (and (< (point) eol) (not (eobp)))
(forward-sexp 1))
(scan-error nil)))
(point))
which can easily include two or more sexps after point. This looks like
a major breakage.
next reply other threads:[~2019-04-15 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 12:14 Leo Liu [this message]
2019-04-15 23:57 ` bug#35286: 26.2; indent-sexp broken Noam Postavsky
2019-04-16 0:35 ` Leo Liu
2019-04-16 0:54 ` Noam Postavsky
2019-04-16 3:19 ` Leo Liu
2019-04-16 12:16 ` Noam Postavsky
2019-04-16 12:57 ` Leo Liu
2019-04-16 13:13 ` Leo Liu
2019-04-21 8:41 ` Leo Liu
2019-04-22 16:51 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m136mjzcql.fsf@gmail.com \
--to=sdl.web@gmail.com \
--cc=35286@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.